-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-166356 [MEP][NALA] Fragment autoload according to Geo #3544
base: stage
Are you sure you want to change the base?
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3544 +/- ##
==========================================
+ Coverage 96.47% 96.48% +0.01%
==========================================
Files 260 260
Lines 60582 60582
==========================================
+ Hits 58444 58451 +7
+ Misses 2138 2131 -7 ☔ View full report in Codecov by Sentry. |
|
Reminder to set the |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
When using the same manifest as the US page, a localized page should use a localized fragment with the same file name/location relative to the geo file structure.
Resolves: MWPW-166356
Test URLs:
FR: https://main--milo--adobecom.hlx.page/fr/drafts/nala/features/personalization/fragment-autoload/autofragbasepage
US: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/fragment-autoload/autofragbasepage
There are instructions on these pages about the expectations.
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://fragment-autoload2--milo--adobecom.aem.page/?martech=off