Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166356 [MEP][NALA] Fragment autoload according to Geo #3544

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Jan 24, 2025

When using the same manifest as the US page, a localized page should use a localized fragment with the same file name/location relative to the geo file structure.

Resolves: MWPW-166356

Test URLs:
FR: https://main--milo--adobecom.hlx.page/fr/drafts/nala/features/personalization/fragment-autoload/autofragbasepage
US: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/fragment-autoload/autofragbasepage
There are instructions on these pages about the expectations.

Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://fragment-autoload2--milo--adobecom.aem.page/?martech=off

Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (6cb26a3) to head (5efb6bd).
Report is 38 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3544      +/-   ##
==========================================
+ Coverage   96.47%   96.48%   +0.01%     
==========================================
  Files         260      260              
  Lines       60582    60582              
==========================================
+ Hits        58444    58451       +7     
+ Misses       2138     2131       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants