Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOTCOM-128841, DOTCOM-129276, Group of navigation links missing semantics #3559

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

patel-prince
Copy link
Contributor

@patel-prince patel-prince commented Jan 28, 2025

Brief description of the issue:
A visual group of navigation links is not marked up semantically to convey their relationship. Some possible solutions include using list(s), role of navigation, nav element, headings, menu or menubar.

Note: changes has been tested using macos's voice over.

Resolves: DOTCOM-128841 and DOTCOM-129276

Test URLs:

QA URL for DOTCOM-129276:
Before: https://main--cc--adobecom.hlx.page/creativecloud?martech=off
After: https://main--cc--adobecom.hlx.page/creativecloud?martech=off&milolibs=dotcom-129276--milo--patel-prince

QA URL for DOTCOM-128841:
Before: https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?martech=off
After: https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?martech=off&milolibs=dotcom-129276--milo--patel-prince

Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (0a9e222) to head (8898b2f).
Report is 45 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3559      +/-   ##
==========================================
+ Coverage   96.49%   96.50%   +0.01%     
==========================================
  Files         260      260              
  Lines       60763    60765       +2     
==========================================
+ Hits        58632    58641       +9     
+ Misses       2131     2124       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa
Copy link

Waiting for the Confirmation from Taryn , on the fix given. Once we have the confirmation will add the details and label .

@prativas22
Copy link

prativas22 commented Feb 4, 2025

The visual group of navigation links was verified by the PR, and their relationship was observed by means of semantic marking. Lists are shown for headings, menus, menubars, navigation, and nav elements.

https://main--cc--adobecom.hlx.page/creativecloud?martech=off&milolibs=dotcom-129276--milo--patel-prince
image

https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?milolibs=dotcom-129276--milo--patel-prince
image

@prativas22 prativas22 added the verified PR has been E2E tested by a reviewer label Feb 4, 2025
@spadmasa spadmasa removed the verified PR has been E2E tested by a reviewer label Feb 5, 2025
@spadmasa
Copy link

spadmasa commented Feb 5, 2025

As there is updated from Taryn on ticket https://jira.corp.adobe.com/browse/DOTCOM-128841 , removing label will be reverified again after the fix

Copy link
Contributor

github-actions bot commented Feb 7, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

…COM-129276
@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage labels Feb 14, 2025
@milo-pr-merge milo-pr-merge bot merged commit 896f5f5 into adobecom:stage Feb 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants