-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOTCOM-128841, DOTCOM-129276, Group of navigation links missing semantics #3559
Conversation
…tics
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3559 +/- ##
==========================================
+ Coverage 96.49% 96.50% +0.01%
==========================================
Files 260 260
Lines 60763 60765 +2
==========================================
+ Hits 58632 58641 +9
+ Misses 2131 2124 -7 ☔ View full report in Codecov by Sentry. |
Reminder to set the |
Waiting for the Confirmation from Taryn , on the fix given. Once we have the confirmation will add the details and label . |
The visual group of navigation links was verified by the PR, and their relationship was observed by means of semantic marking. Lists are shown for headings, menus, menubars, navigation, and nav elements. https://main--cc--adobecom.hlx.page/creativecloud?martech=off&milolibs=dotcom-129276--milo--patel-prince https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?milolibs=dotcom-129276--milo--patel-prince |
As there is updated from Taryn on ticket https://jira.corp.adobe.com/browse/DOTCOM-128841 , removing label will be reverified again after the fix |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
…COM-129276
The visual group of navigation links was verified by the PR. https://main--cc--adobecom.hlx.page/creativecloud?martech=off&milolibs=dotcom-129276--milo--patel-prince https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?milolibs=dotcom-129276--milo--patel-prince |
Brief description of the issue:
A visual group of navigation links is not marked up semantically to convey their relationship. Some possible solutions include using list(s), role of navigation, nav element, headings, menu or menubar.
Note: changes has been tested using macos's voice over.
Resolves: DOTCOM-128841 and DOTCOM-129276
Test URLs:
QA URL for DOTCOM-129276:
Before: https://main--cc--adobecom.hlx.page/creativecloud?martech=off
After: https://main--cc--adobecom.hlx.page/creativecloud?martech=off&milolibs=dotcom-129276--milo--patel-prince
QA URL for DOTCOM-128841:
Before: https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?martech=off
After: https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?martech=off&milolibs=dotcom-129276--milo--patel-prince