Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-163512: Fix masonry full-width for tablet #3567

Merged
merged 1 commit into from
Jan 30, 2025
Merged

MWPW-163512: Fix masonry full-width for tablet #3567

merged 1 commit into from
Jan 30, 2025
+1 −1

Conversation

zagi25
Copy link
Contributor

@zagi25 zagi25 commented Jan 28, 2025 •
edited by mokimo
Loading

@zagi25 zagi25 requested a review from a team January 28, 2025 13:41
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025 •
edited
Loading

Page Scores Audits Google
📱 /drafts/ratko/mwpw-163512/brick-bg?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/ratko/mwpw-163512/brick-bg?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (0a9e222) to head (791c8ae).
Report is 20 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3567      +/-   ##
==========================================
+ Coverage   96.49%   96.50%   +0.01%     
==========================================
  Files         260      260              
  Lines       60763    60763              
==========================================
+ Hits        58632    58639       +7     
+ Misses       2131     2124       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

overmyheadandbody
overmyheadandbody approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'm glad this wasn't more convoluted 😃

@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Jan 30, 2025
NadiiaSokolova
NadiiaSokolova approved these changes Jan 30, 2025
View reviewed changes
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-163512

@milo-pr-merge milo-pr-merge bot merged commit 2cc493f into stage Jan 30, 2025
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-163512-bg-image-tablet branch January 30, 2025 15:30
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NadiiaSokolova NadiiaSokolova NadiiaSokolova approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@narcis-radu narcis-radu narcis-radu approved these changes

Assignees

@NadiiaSokolova NadiiaSokolova

Labels
Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zagi25 @narcis-radu @overmyheadandbody @NadiiaSokolova