Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-156760] Table caret position #3568

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

DKos95
Copy link
Contributor

@DKos95 DKos95 commented Jan 28, 2025

Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (0a9e222) to head (65d80cf).
Report is 21 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3568      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.01%     
==========================================
  Files         260      260              
  Lines       60763    60810      +47     
==========================================
+ Hits        58632    58673      +41     
- Misses       2131     2137       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DKos95 DKos95 force-pushed the table-caret-position branch from 5ffb5bd to 50bb653 Compare January 28, 2025 14:42
@aem-code-sync aem-code-sync bot temporarily deployed to table-caret-position January 28, 2025 14:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to table-caret-position January 28, 2025 15:29 Inactive
Comment on lines 360 to 361
width: 12px;
height: 17px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these specific values coming from? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a chevron icon in the project already and without uploading a new one I tried to make it look as close to the design as possible since the original is a bit too big. If your concern here is the focus box is not even we can get the height to be 12px also, but the icon when tabbing is not being focused but the cell in the table.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the height declaration is ideal. The icon seems to be 17x10px, so setting a height larger than the width might not achieve anything extra. We could set the height to 100% (also technically incorrect, but more general than 17px) or remove the height and set an aspect-ratio: 1.7.

Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small improvement suggestion.

Comment on lines 360 to 361
width: 12px;
height: 17px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the height declaration is ideal. The icon seems to be 17x10px, so setting a height larger than the width might not achieve anything extra. We could set the height to 100% (also technically incorrect, but more general than 17px) or remove the height and set an aspect-ratio: 1.7.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@SilviuLCF SilviuLCF self-requested a review January 30, 2025 07:59
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milo-pr-merge milo-pr-merge bot merged commit 38c430d into stage Jan 30, 2025
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the table-caret-position branch January 30, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants