Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOC] Milostudio stage to milostudio #3573

Merged
merged 13 commits into from
Jan 29, 2025
Merged

[LOC] Milostudio stage to milostudio #3573

merged 13 commits into from
Jan 29, 2025

Conversation

nkthakur48
Copy link
Contributor

nkthakur48 and others added 13 commits January 23, 2025 13:13
@nkthakur48
MWPW-165749 Updated label for custom merge
47244f4
@saurabhsircar11
MWPW-165573 - limit for project name
922a74f 
* Added max length to restrict more than 50 chars

Resolves:https://jira.corp.adobe.com/browse/MWPW-165573

**Test URLs:**
- Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off
- After: https://MWPW-165573--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
@nkthakur48
MWPW-165749 Updated label for custom merge (#3534)
55f5250
@nkthakur48
MWPW-165573 - limit for project name (#3533)
17c2449
@saurabhsircar11
MWPW-165575 - url validation
ca6e3d1 
* Added a regex for url validation

Resolves:https://jira.corp.adobe.com/browse/MWPW-165575

**Test URLs:**
- Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off
- After: https://MWPW-165575-url-validation--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off
@nkthakur48
[LOC] MWPW-165575: Url validation in url input screen (#3535)
a49735e
@nkthakur48
MWPW-166465 Checking language details after lowercasing
b5900f1
@nkthakur48
MWPW-166465 Handled Eslint warnings
581a0e0
@nkthakur48
MWPW-166465 Eslint check
34e35ad
@nkthakur48
MWPW-166465 Handle Eslint Issues
6b71a24
@nkthakur48
MWPW-166465 Eslint fix
115a86c
@nkthakur48
MWPW-166465 Fixing Eslint issue
f36a15d
@nkthakur48
MWPW-166465 Checking language details after lowercasing (#3550)
5e86bc3
@nkthakur48 nkthakur48 added the trivial PR doesn't require E2E testing by a reviewer label Jan 29, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 29, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 29, 2025

Page Scores Audits Google
📱 /drafts/sircar/locui-create?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sircar/locui-create?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nkthakur48 nkthakur48 merged commit 86884fe into milostudio Jan 29, 2025
10 of 11 checks passed
@nkthakur48 nkthakur48 deleted the milostudio-stage branch January 29, 2025 09:03
@nkthakur48 nkthakur48 restored the milostudio-stage branch January 29, 2025 09:17
@aem-code-sync aem-code-sync bot temporarily deployed to milostudio-stage January 29, 2025 09:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maagrawal16 maagrawal16 maagrawal16 approved these changes

@saurabhsircar11 saurabhsircar11 saurabhsircar11 approved these changes

@hnvadobe hnvadobe Awaiting requested review from hnvadobe

Assignees
No one assigned
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkthakur48 @saurabhsircar11 @maagrawal16