Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-165978] Make codecov tests more reliable #3588

Merged
merged 3 commits into from
Feb 3, 2025
Merged

[MWPW-165978] Make codecov tests more reliable #3588

merged 3 commits into from
Feb 3, 2025

Conversation

robert-bogos
Copy link
Contributor

Description

This PR is:

  • increasing the tolerance threshold for codecov to 0.5%.
  • including only what's under the libs/ folder for codecov.
  • excluding libs/deps from codecov.

Related Issue

Resolves: MWPW-165978

Testing instructions

  • no QA needed

Test URLs

Milo:

@robert-bogos robert-bogos added trivial PR doesn't require E2E testing by a reviewer zero-impact labels Jan 30, 2025
@robert-bogos robert-bogos requested a review from a team January 30, 2025 09:36
@robert-bogos robert-bogos self-assigned this Jan 30, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 30, 2025 •
edited
Loading

Page Scores Audits Google
📱 /drafts/rbogos/page-default?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/rbogos/page-default?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

mokimo
mokimo reviewed Jan 30, 2025
View reviewed changes
codecov.yaml Outdated Show resolved Hide resolved
overmyheadandbody
overmyheadandbody approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We've been wanting to limit this to libs for a while now, great to see it happening.

codecov.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

narcis-radu
narcis-radu approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@narcis-radu narcis-radu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

@milo-pr-merge milo-pr-merge bot merged commit 4e7c996 into adobecom:stage Feb 3, 2025
16 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Feb 3, 2025
Merged
colloyd pushed a commit to colloyd/milo that referenced this pull request Feb 6, 2025
@robert-bogos @colloyd
[MWPW-165978] Make codecov tests more reliable (adobecom#3588)
cbd5b97 
* codecov test changes

* hotfix

* hotfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narcis-radu narcis-radu narcis-radu approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@mokimo mokimo mokimo approved these changes

Assignees

@robert-bogos robert-bogos

Labels
Ready for Stage trivial PR doesn't require E2E testing by a reviewer zero-impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robert-bogos @narcis-radu @overmyheadandbody @mokimo