Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-166712] Redesign MEP button and MMM expanded interface #3653

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

AdobeLinhart
Copy link
Contributor

@AdobeLinhart AdobeLinhart commented Feb 7, 2025

Rework MEP button to match Figma design. Retain all existing functionality. MMM styling needs to be presentable and will be updated in a separate PR.

Resolves: MWPW-166712

Instructions:
Test all MEP button functionality. Verify MEP button matches design.

Test URLs:
MEP Button

MMM

Copy link
Contributor

aem-code-sync bot commented Feb 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 7, 2025

Page Scores Audits Google
📱 /docs/authoring/features/mmm?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

github-actions bot commented Feb 8, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

@jpratt2 jpratt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. I verified that the content matches the content in an old manifest and that the options still work

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants