-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for AdonisJS Governance #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-R44
approved these changes
Feb 25, 2024
@RomainLanz @targos Do you guys have any feedback? |
RomainLanz
approved these changes
Mar 7, 2024
LGTM! |
targos
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions based on grammar checkers.
targos
approved these changes
Mar 7, 2024
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The governance model is built around the physical reality of our setup, and some inspiration is taken from the following projects.
Apart from the following projects, I also looked at TailwindCSS, FilamentPhp, TanStack, and Hono, but they have not publicly published any formal governance model.
The "Decision making process" is not yet documented. For that, I will submit another proposal titled "How we work" and abstract the decision making process from it.