Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pathprefixer): correctly prefix root (./) directory #49

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Ruby184
Copy link

@Ruby184 Ruby184 commented Jan 9, 2023

Proposed changes

Fix case when using PathPrefixer.prefixDirectoryPath for list with s3 and gcs.
When passing root directory ., / or ./ we should return empty prefix ''.
Added tests for failing cases before this change.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

Prerequisite for correctly working list for s3 and gcs drivers (I will create PRs).

@thetutlage
Copy link
Member

Cool, thanks!

@thetutlage thetutlage merged commit 23ebcc0 into adonisjs:develop Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants