Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle writeOptions when diskNameOrOptions is provided #55

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kamilcglr
Copy link
Contributor

πŸ”— Linked issue

#54

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixed the moveToDisk function of the MultipartFile helper to correctly handle writeOptions when diskNameOrOptions is provided, ensuring that writeOptions are no longer ignored.
Resolves #54

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit cbc7601 into adonisjs:develop Sep 26, 2024
8 checks passed
@thetutlage
Copy link
Member

Thanks πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultipartFile helper’s moveToDisk method does not add writeOptions
2 participants