fix / add benchmarks

pgpq/Cargo.toml

@@ -23,7 +23,12 @@ features = ["chrono-tz"]
 rstest = ">=0.16.0"
 parquet = ">=32.0.0"
 criterion = ">=0.4.0"
+arrow = ">=32.0.0"
 
 [[bench]]
 name = "benchmarks"
 harness = false
+
+[[bench]]
+name = "columnar_vs_rows"
+harness = false

pgpq/benches/benchmarks.rs

@@ -5,7 +5,7 @@ use arrow::datatypes::{DataType, Schema, TimeUnit};
 use arrow::record_batch::RecordBatchReader;
 use arrow_array::RecordBatch;
 use bytes::BytesMut;
-use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use criterion::{criterion_group, criterion_main, Criterion};
 use parquet::arrow::arrow_reader::{ParquetRecordBatchReader, ParquetRecordBatchReaderBuilder};
 use pgpq::ArrowToPostgresBinaryEncoder;
 use std::fs;
@@ -53,14 +53,5 @@ pub fn benchmark_nyc_taxi_full(c: &mut Criterion) {
     });
 }
 
-pub fn benchmark_approaches(c: &mut Criterion) {
-    let mut group = c.benchmark_group("benchmark_approaches");
-    group.bench_function("dyn_to_buffer", |b| {
-        b.iter_with_setup(|| setup(None), |(records, schema) {
-            let out =
-        })
-    });
-}
-
-criterion_group!(benches, benchmark_nyc_taxi_small, benchmark_nyc_taxi_full, benchmark_dyn_to_buffer);
+criterion_group!(benches, benchmark_nyc_taxi_small, benchmark_nyc_taxi_full);
 criterion_main!(benches);