Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type definations for class 'rule' to get ts support. #160

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

Basavarajrp
Copy link
Contributor

@Basavarajrp Basavarajrp commented Oct 28, 2024

Add TypeScript Declarations for Rule Class.

This was related to issue. I just added the type definition for the Rule class alone.

@Basavarajrp Basavarajrp mentioned this pull request Oct 28, 2024
adrienjoly
adrienjoly previously approved these changes Nov 3, 2024
Copy link
Owner

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding types!

Can you just reformat the file using npm run prettier:fix and commit, before we merge the PR, please?

@Basavarajrp
Copy link
Contributor Author

Thank you for adding types!

Can you just reformat the file using npm run prettier:fix and commit, before we merge the PR, please?

Done @adrienjoly

@adrienjoly adrienjoly merged commit 0c44224 into adrienjoly:master Nov 3, 2024
5 checks passed
@Basavarajrp
Copy link
Contributor Author

@adrienjoly I'm happy to see my first open source PR getting merged! This is my first open source contribution. Thank you so much!

@adrienjoly
Copy link
Owner

Congrats! 🎉
Good job and thank you for your contribution :-)

@CalderWhite
Copy link

You need to publish a release for people to use this feature. The latest npm release doesn't have this, and when you try to use the git repo there are module issues since the ci build:cjs step is required to add support here.

I am using my own fork of this in the meantime. I'll take it down once the release is published to npm.

Copy link

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@adrienjoly
Copy link
Owner

@CalderWhite thanks for the heads up! the release didn't work because I had forgotten to rename your PR as a semantic commit => the release manager didn't know if it had to increment the patch, minor or major part of the version.

@CalderWhite
Copy link

Not my change, but happy to take credit! 😆 . Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants