-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type definations for class 'rule' to get ts support. #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding types!
Can you just reformat the file using npm run prettier:fix
and commit, before we merge the PR, please?
Done @adrienjoly |
@adrienjoly I'm happy to see my first open source PR getting merged! This is my first open source contribution. Thank you so much! |
Congrats! 🎉 |
You need to publish a release for people to use this feature. The latest npm release doesn't have this, and when you try to use the git repo there are module issues since the ci I am using my own fork of this in the meantime. I'll take it down once the release is published to npm. |
🎉 This PR is included in version 3.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@CalderWhite thanks for the heads up! the release didn't work because I had forgotten to rename your PR as a semantic commit => the release manager didn't know if it had to increment the patch, minor or major part of the version. |
Not my change, but happy to take credit! 😆 . Thanks for the quick response! |
Add TypeScript Declarations for Rule Class.
This was related to issue. I just added the type definition for the Rule class alone.