Skip to content

Commit

Permalink
OAK-6511 - Switch to official OSGi versioning annotations
Browse files Browse the repository at this point in the history
Changes the annotations from aQute.bnd.annotation to
org.osgi.annotation.versioning. As the baselining checks have complained,
some packages received a micro version bump. This should be harmless however,
import ranges are at most minor, and usually major.

In some modules the bndlib dependency was outright removed, as it was not
used at all.

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/oak/trunk@1804431 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
rombert committed Aug 8, 2017
1 parent 956b01e commit a5b63fd
Show file tree
Hide file tree
Showing 86 changed files with 102 additions and 176 deletions.
4 changes: 2 additions & 2 deletions oak-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.annotation</artifactId>
<scope>provided</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import java.util.Map;
import java.util.Set;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* The query engine allows to parse and execute queries.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/
package org.apache.jackrabbit.oak.api.jmx;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

@ProviderType
public interface CacheStatsMBean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import javax.management.openmbean.CompositeData;
import javax.management.openmbean.TabularData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

import java.util.Date;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import javax.management.openmbean.TabularData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

@ProviderType
public interface ConsolidatedCacheStatsMBean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.jackrabbit.oak.api.jmx;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

import javax.management.openmbean.TabularData;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import javax.annotation.Nonnull;
import javax.management.openmbean.CompositeData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* MBean for backing up and restoring a {@code NodeStore}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import javax.management.openmbean.CompositeData;
import javax.management.openmbean.TabularData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

@ProviderType
public interface IndexStatsMBean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

import java.io.IOException;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;
import org.apache.jackrabbit.oak.api.CommitFailedException;

@ProviderType
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* limitations under the License.
*/

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

import javax.management.openmbean.CompositeData;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/
package org.apache.jackrabbit.oak.api.jmx;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

@ProviderType
public interface QueryEngineSettingsMBean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import javax.management.openmbean.CompositeData;
import javax.management.openmbean.TabularData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* This interface exposes repository management operations and the status
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import javax.management.openmbean.CompositeData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* MBean for providing repository wide statistics.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.jackrabbit.oak.api.jmx;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;
import org.apache.jackrabbit.oak.api.AuthInfo;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
*/

@Version("4.7.0")
@Export(optional = "provide:=true")
package org.apache.jackrabbit.oak.api.jmx;

import aQute.bnd.annotation.Export;
import aQute.bnd.annotation.Version;
import org.osgi.annotation.versioning.Version;

Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@
/**
* Oak repository API
*/
@Version("3.1.0")
@Export(optional = "provide:=true")
@Version("3.1.1")
package org.apache.jackrabbit.oak.api;

import aQute.bnd.annotation.Export;
import aQute.bnd.annotation.Version;
import org.osgi.annotation.versioning.Version;

10 changes: 5 additions & 5 deletions oak-auth-external/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,16 @@
<artifactId>org.apache.felix.jaas</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.annotation</artifactId>
<scope>provided</scope>
</dependency>

<!-- Jackrabbit dependencies -->
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
* limitations under the License.
*/
@Version("1.3.0")
@Export
package org.apache.jackrabbit.oak.spi.security.authentication.external.basic;

import aQute.bnd.annotation.Version;
import aQute.bnd.annotation.Export;
import org.osgi.annotation.versioning.Version;
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import javax.annotation.Nonnull;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* Provides utilities to manage synchronized external identities.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
* limitations under the License.
*/
@Version("2.3.0")
@Export
package org.apache.jackrabbit.oak.spi.security.authentication.external;

import aQute.bnd.annotation.Version;
import aQute.bnd.annotation.Export;
import org.osgi.annotation.versioning.Version;
5 changes: 0 additions & 5 deletions oak-auth-ldap/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@
<version>2.7.7</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions oak-authorization-cug/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.annotation</artifactId>
<scope>provided</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@
import org.apache.jackrabbit.oak.spi.security.principal.AdminPrincipal;
import org.apache.jackrabbit.oak.spi.security.principal.SystemPrincipal;
import org.apache.jackrabbit.oak.spi.security.principal.SystemUserPrincipal;
import org.osgi.annotation.versioning.ProviderType;

/**
* Interface that allows to exclude certain principals from the CUG evaluation.
* For the excluded principals the closed user group policies will be ignored.
*/
@ProviderType
public interface CugExclude {

boolean isExcluded(@Nonnull Set<Principal> principals);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@

import org.apache.jackrabbit.api.security.JackrabbitAccessControlPolicy;
import org.apache.jackrabbit.api.security.authorization.PrincipalSetPolicy;
import org.osgi.annotation.versioning.ProviderType;

/**
* Denies read access for all principals except for the specified principals.
*/
@ProviderType
public interface CugPolicy extends PrincipalSetPolicy, JackrabbitAccessControlPolicy {

}
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
@Version("2.0.0")
@Export(optional = "provide:=true")
@Version("2.0.1")
package org.apache.jackrabbit.oak.spi.security.authorization.cug;

import aQute.bnd.annotation.Export;
import aQute.bnd.annotation.Version;
import org.osgi.annotation.versioning.Version;
5 changes: 0 additions & 5 deletions oak-blob-cloud-azure/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,6 @@
<artifactId>org.osgi.compendium</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions oak-blob-cloud/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@
<artifactId>org.osgi.compendium</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions oak-blob-plugins/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@
<artifactId>org.osgi.compendium</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions oak-blob/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.annotation</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/
package org.apache.jackrabbit.oak.spi.blob;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

import java.io.IOException;
import java.util.Iterator;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import java.util.concurrent.TimeUnit;

import aQute.bnd.annotation.ConsumerType;
import org.osgi.annotation.versioning.ConsumerType;

/**
* BlobStoreStatsCollector receives callback when blobs are written and read
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import javax.management.openmbean.CompositeData;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

@ProviderType
public interface BlobStoreStatsMBean {
Expand Down
5 changes: 0 additions & 5 deletions oak-commons/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions oak-core-spi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>biz.aQute.bnd</groupId>
<artifactId>biz.aQute.bndlib</artifactId>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.annotation</artifactId>
<scope>provided</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.jackrabbit.oak.spi.mount;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* Refers to a set of paths from a <tt>ContentRepository</tt> that are possibly
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import javax.annotation.CheckForNull;
import javax.annotation.Nonnull;

import aQute.bnd.annotation.ProviderType;
import org.osgi.annotation.versioning.ProviderType;

/**
* Holds information related to the {@link Mount}s configured in a <tt>ContentRepository</tt>.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
@Version("3.0.0")
package org.apache.jackrabbit.oak.spi.mount;

import aQute.bnd.annotation.Version;
import org.osgi.annotation.versioning.Version;
Loading

0 comments on commit a5b63fd

Please sign in to comment.