Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anthony venturini #1

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Anthony venturini #1

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8909588
anthony-venturini
adventurini Jan 28, 2019
45ea580
I am the worst at commits. MVP met.
adventurini Jan 28, 2019
ac975fd
MVP met now actually. Added two items to the navigation
adventurini Jan 28, 2019
5cea7ca
MVP, no really, MVP is finally met. Changed navigation colors to green
adventurini Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MVP, no really, MVP is finally met. Changed navigation colors to green
  • Loading branch information
@adventurini
adventurini committed Jan 28, 2019
commit 5cea7cabbecd85a048095cca26e7e2fba2551517
9 changes: 9 additions & 0 deletions js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,21 @@ navA[3].textContent= siteContent["nav"]["nav-item-4"];
navA[4].textContent= siteContent["nav"]["nav-item-5"];
navA[5].textContent= siteContent["nav"]["nav-item-6"];

navA[0].style.color= 'green';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
navA[0].style.color= 'green';
navItems.forEach(item => item.style.color = 'green');

navA[1].style.color= 'green';
navA[2].style.color= 'green';
navA[3].style.color= 'green';
navA[4].style.color= 'green';
navA[5].style.color= 'green';

var home = document.createElement("a");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var home = document.createElement("a");
const home = document.createElement("a");

home.innerText = "Home"
home.href = '#';
home.style.color='green';
var blog = document.createElement("a");
blog.innerText = "Blog";
blog.href='#';
blog.style.color = 'green';

nav.prepend(home);
nav.appendChild(blog);
Expand Down