Skip to content

Commit

Permalink
tests: Remove dump when cluster-up fails
Browse files Browse the repository at this point in the history
"make dump" needs a valid cluster KUBECONFIG,
so if cluster-up failed, it doesn't make sense.
It also hides and error, and we need to scroll a bit
to find the fact cluster-up failed, instead seeing it directly.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Apr 21, 2024
1 parent 6893cf9 commit c2bfd3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion automation/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export IMAGE_PREFIX_ALT=${IMAGE_PREFIX_ALT:-kv-}

build_images

trap '{ collect_debug_logs; echo "Dump kubevirt state:"; make dump; }' ERR
trap '{ collect_debug_logs; }' ERR
make cluster-up
trap - ERR

Expand Down

0 comments on commit c2bfd3d

Please sign in to comment.