Skylint: add integration tests for the java binary

RELNOTES: none
PiperOrigin-RevId: 171526636

src/test/skylark/BUILD

@@ -8,7 +8,7 @@ package(default_visibility = ["//src:__subpackages__"])
 
 filegroup(
     name = "srcs",
-    srcs = glob(["**"]),
+    srcs = glob(["**"]) + ["//src/test/skylark/skylint:srcs"],
 )
 
 py_test(

src/test/skylark/skylint/BUILD

@@ -0,0 +1,17 @@
+package(default_visibility = ["//src:__subpackages__"])
+
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+)
+
+py_test(
+    name = "skylint_test",
+    srcs = [
+        "skylint_test.py",
+        "testenv.py",
+    ],
+    data = ["//src/tools/skylark/java/com/google/devtools/skylark/skylint:Skylint"] + glob([
+        "testdata/*",
+    ]),
+)

src/test/skylark/skylint/skylint_test.py

@@ -0,0 +1,51 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os.path
+import subprocess
+import unittest
+
+from src.test.skylark.skylint import testenv
+
+
+class SkylintTest(unittest.TestCase):
+
+  def testGoodFile(self):
+    output = subprocess.check_output([
+        testenv.SKYLINT_BINARY_PATH,
+        os.path.join(testenv.SKYLINT_TESTDATA_PATH, "good.bzl.test")
+    ])
+    self.assertEqual(output, "")
+
+  def testBadFile(self):
+    try:
+      issues = ""
+      subprocess.check_output([
+          testenv.SKYLINT_BINARY_PATH,
+          os.path.join(testenv.SKYLINT_TESTDATA_PATH, "bad.bzl.test")
+      ])
+    except subprocess.CalledProcessError as e:
+      issues = e.output
+    self.assertIn("no module docstring", issues)
+
+  def testDisablingChecker(self):
+    output = subprocess.check_output([
+        testenv.SKYLINT_BINARY_PATH, "--disable=docstring",
+        os.path.join(testenv.SKYLINT_TESTDATA_PATH, "bad.bzl.test")
+    ])
+    self.assertEqual(output, "")
+
+
+if __name__ == "__main__":
+  unittest.main()

src/test/skylark/skylint/testdata/bad.bzl.test

@@ -0,0 +1,15 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+print('Docstring missing')

src/test/skylark/skylint/testdata/good.bzl.test

@@ -0,0 +1,15 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""This is a docstring."""

src/test/skylark/skylint/testenv.py

@@ -0,0 +1,17 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""Test constants for src/test/skylark/skylint."""
+
+SKYLINT_BINARY_PATH = "src/tools/skylark/java/com/google/devtools/skylark/skylint/Skylint"
+SKYLINT_TESTDATA_PATH = "src/test/skylark/skylint/testdata/"

src/tools/skylark/java/com/google/devtools/skylark/skylint/BUILD

@@ -5,6 +5,7 @@ java_binary(
     name = "Skylint",
     srcs = [],
     main_class = "com.google.devtools.skylark.skylint.Skylint",
+    visibility = ["//src/test/skylark/skylint:__pkg__"],
     runtime_deps = [
         ":skylint_lib",
     ],