chore(deps): Bump the dependencies group across 1 directory with 3 up…

…dates (puppeteer#12690) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikolay Vitkov <[email protected]> Co-authored-by: Maksim Sadym <[email protected]>
aguidrevitch · Jul 1, 2024 · 7773067 · 7773067
1 parent a18c86a
commit 7773067
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -137,7 +137,7 @@
   },
   "devDependencies": {
     "@actions/core": "1.10.1",
-    "@types/mocha": "10.0.6",
+    "@types/mocha": "10.0.7",
     "@types/node": "20.8.4",
     "@types/semver": "7.5.8",
     "@types/sinon": "17.0.3",
@@ -158,7 +158,7 @@
     "gts": "5.3.1",
     "hereby": "1.8.9",
     "license-checker": "25.0.1",
-    "mocha": "10.4.0",
+    "mocha": "10.5.2",
     "npm-run-all2": "6.2.0",
     "prettier": "3.3.2",
     "semver": "7.6.2",

diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -120,7 +120,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@puppeteer/browsers": "2.2.3",
-    "chromium-bidi": "0.5.24",
+    "chromium-bidi": "0.6.0",
     "debug": "^4.3.5",
     "devtools-protocol": "0.0.1299070",
     "ws": "^8.17.1"

diff --git a/packages/puppeteer-core/src/bidi/BidiOverCdp.ts b/packages/puppeteer-core/src/bidi/BidiOverCdp.ts
@@ -5,7 +5,7 @@
  */
 
 import * as BidiMapper from 'chromium-bidi/lib/cjs/bidiMapper/BidiMapper.js';
-import type * as Bidi from 'chromium-bidi/lib/cjs/protocol/protocol.js';
+import * as Bidi from 'chromium-bidi/lib/cjs/protocol/protocol.js';
 import type {ProtocolMapping} from 'devtools-protocol/types/protocol-mapping.js';
 
 import type {CDPEvents, CDPSession} from '../api/CDPSession.js';
@@ -59,7 +59,14 @@ export async function connectBidiOverCdp(
     // TODO: most likely need a little bit of refactoring
     cdpConnectionAdapter.browserClient(),
     '',
-    options,
+    {
+      // Override Mapper's `unhandledPromptBehavior` default value of `dismiss` to
+      // `ignore`, so that user can handle the prompt instead of just closing it.
+      unhandledPromptBehavior: {
+        default: Bidi.Session.UserPromptHandlerType.Ignore,
+      },
+      ...options,
+    },
     undefined,
     bidiServerLogger
   );

diff --git a/test/installation/package.json b/test/installation/package.json
@@ -46,6 +46,6 @@
   ],
   "dependencies": {
     "glob": "10.4.2",
-    "mocha": "10.4.0"
+    "mocha": "10.5.2"
   }
 }