MDL-77164 privacy: typehint test content writer

admin/roles/tests/privacy/provider_test.php

@@ -53,6 +53,7 @@ public function test_export_user_preferences() {
         $showadvanced = 1;
         set_user_preference('definerole_showadvanced', $showadvanced);
         provider::export_user_preferences($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context(\context_system::instance());
         $prefs = $writer->get_user_preferences('core_role');
         $this->assertEquals(transform::yesno($showadvanced), transform::yesno($prefs->definerole_showadvanced->value));
@@ -184,6 +185,7 @@ public function test_export_user_data() {
         // Retrieve role capabilities and role assignments.
         provider::export_user_data($approvedcontextlist);
         foreach ($contextlist as $context) {
+            /** @var \core_privacy\tests\request\content_writer $writer */
             $writer = writer::with_context($context);
             $this->assertTrue($writer->has_any_data());
             if ($context->contextlevel == CONTEXT_MODULE) {
@@ -413,6 +415,7 @@ public function test_export_user_role_to_cohort() {
         ];
         // Test User is assigned role teacher to cohort.
         provider::export_user_role_to_cohort($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($contextuserassignover);
         $this->assertTrue($writer->has_any_data());
         $exported = (array)$writer->get_related_data($subcontextteacher, 'cohortroles');
@@ -430,6 +433,7 @@ public function test_export_user_role_to_cohort() {
         api::create_cohort_role_assignment($params);
         api::sync_all_cohort_roles();
         provider::export_user_role_to_cohort($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($contextuser);
         $this->assertTrue($writer->has_any_data());
         $exported = (array)$writer->get_related_data($subcontextteacher, 'cohortroles');

admin/tool/mobile/tests/privacy/provider_test.php

@@ -111,6 +111,7 @@ public function test_export_user_data() {
         $key = $DB->get_record('user_private_key', ['value' => $keyvalue]);
         // Validate exported data.
         $this->setUser($user);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
         $this->export_context_data_for_user($user->id, $context, 'tool_mobile');

auth/mnet/tests/privacy/provider_test.php

@@ -106,6 +106,7 @@ public function test_export_user_data() {
 
         $usercontext = \context_user::instance($user->id);
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($usercontext);
         $this->assertFalse($writer->has_any_data());
         $approvedlist = new approved_contextlist($user, 'auth_mnet', [$usercontext->id]);

blocks/html/tests/privacy/provider_test.php

@@ -185,6 +185,7 @@ public function test_user_block() {
 
         // Export the data.
         $this->export_context_data_for_user($user->id, $context, 'block_html');
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = \core_privacy\local\request\writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
 
@@ -233,6 +234,7 @@ public function test_user_block_unconfigured() {
 
         // Export the data.
         $this->export_context_data_for_user($user->id, $context, 'block_html');
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = \core_privacy\local\request\writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
     }

calendar/tests/privacy/provider_test.php

@@ -180,6 +180,7 @@ public function test_export_user_data() {
         provider::export_user_data($approvedcontextlist);
 
         foreach ($contextlist as $context) {
+            /** @var \core_privacy\tests\request\content_writer $writer */
             $writer = writer::with_context($context);
             $this->assertTrue($writer->has_any_data());
 

enrol/cohort/tests/privacy/provider_test.php

@@ -114,6 +114,7 @@ public function test_export_user_data() {
         $approvedcontextlist = new approved_contextlist($user1, 'enrol_cohort', $contextlist->get_contextids());
         provider::export_user_data($approvedcontextlist);
         foreach ($contextlist as $context) {
+            /** @var \core_privacy\tests\request\content_writer $writer */
             $writer = writer::with_context($context);
             $data = $writer->get_data([
                 get_string('pluginname', 'enrol_cohort'),

enrol/meta/tests/privacy/provider_test.php

@@ -103,6 +103,7 @@ public function test_export_user_data() {
         $approvedcontextlist = new approved_contextlist($user1, 'enrol_meta', $contextlist->get_contextids());
         provider::export_user_data($approvedcontextlist);
         foreach ($contextlist as $context) {
+            /** @var \core_privacy\tests\request\content_writer $writer */
             $writer = writer::with_context($context);
             $data = $writer->get_data([
                 get_string('pluginname', 'enrol_meta'),

grade/grading/form/guide/tests/privacy/provider_test.php

@@ -67,6 +67,7 @@ public function test_export_user_preferences() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('gradingform_guide');

grade/grading/tests/privacy/provider_test.php

@@ -110,6 +110,7 @@ public function test_export_user_data_no_content() {
         $this->setUser($user);
         $context = \context_system::instance();
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
         $this->export_context_data_for_user($user->id, $context, 'core_grading');

grade/report/grader/tests/privacy/provider_test.php

@@ -77,6 +77,7 @@ public function test_export_user_preferences_single() {
         // Validate exported data for our test user.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('gradereport_grader');
@@ -99,6 +100,7 @@ public function test_export_user_preferences_multiple() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('gradereport_grader');

grade/report/user/tests/privacy/provider_test.php

@@ -67,6 +67,7 @@ public function test_export_user_preferences_single() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('gradereport_user');

group/tests/privacy/provider_test.php

@@ -90,6 +90,7 @@ public function test_export_groups() {
 
         // Retrieve groups for user1.
         $this->setUser($user1);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         provider::export_groups($context, '');
 
@@ -134,6 +135,7 @@ public function test_export_groups_for_component() {
 
         // Retrieve groups for user1.
         $this->setUser($user1);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         provider::export_groups($context, 'enrol_self');
 
@@ -792,6 +794,7 @@ public function test_export_user_data() {
         // Export all of the data for the context.
         $this->export_context_data_for_user($user1->id, $context, 'core_group');
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
 

lib/editor/atto/tests/privacy/provider_test.php

@@ -118,6 +118,7 @@ public function test_fetch_and_exports_drafts() {
         // Export the data for the system context.
         // There should be two.
         $this->export_context_data_for_user($user->id, $systemcontext, 'editor_atto');
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = \core_privacy\local\request\writer::with_context($systemcontext);
         $this->assertTrue($writer->has_any_data());
 
@@ -535,6 +536,7 @@ public function test_another_user_edits_you() {
 
         // Should have the data.
         $this->export_context_data_for_user($user->id, $usercontext, 'editor_atto');
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = \core_privacy\local\request\writer::with_context($usercontext);
         $this->assertTrue($writer->has_any_data());
 
@@ -587,6 +589,7 @@ public function test_another_you_edit_different_user() {
 
         // Should have the data.
         $this->export_context_data_for_user($user->id, $otherusercontext, 'editor_atto');
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = \core_privacy\local\request\writer::with_context($otherusercontext);
         $this->assertTrue($writer->has_any_data());
 

lib/editor/tests/privacy/provider_test.php

@@ -47,7 +47,9 @@ public function test_no_preference() {
         $this->setAdminUser();
 
         provider::export_user_preferences($USER->id);
-        $this->assertFalse(writer::with_context(\context_system::instance())->has_any_data());
+        /** @var \core_privacy\tests\request\content_writer $writer */
+        $writer = writer::with_context(\context_system::instance());
+        $this->assertFalse($writer->has_any_data());
     }
 
     /**
@@ -67,7 +69,9 @@ public function test_empty_preference() {
 
         // Export test users preferences.
         provider::export_user_preferences($user->id);
-        $this->assertFalse(writer::with_context(\context_system::instance())->has_any_data());
+        /** @var \core_privacy\tests\request\content_writer $writer */
+        $writer = writer::with_context(\context_system::instance());
+        $this->assertFalse($writer->has_any_data());
     }
 
     /**
@@ -87,9 +91,11 @@ public function test_editor_atto() {
 
         // Export test users preferences.
         provider::export_user_preferences($user->id);
-        $this->assertTrue(writer::with_context(\context_system::instance())->has_any_data());
+        /** @var \core_privacy\tests\request\content_writer $writer */
+        $writer = writer::with_context(\context_system::instance());
+        $this->assertTrue($writer->has_any_data());
 
-        $prefs = writer::with_context(\context_system::instance())->get_user_preferences('core_editor');
+        $prefs = $writer->get_user_preferences('core_editor');
         $this->assertNotEmpty($prefs->htmleditor);
         $this->assertNotEmpty($prefs->htmleditor->value);
         $this->assertNotEmpty($prefs->htmleditor->description);

lib/userkey/tests/privacy/provider_test.php

@@ -70,6 +70,7 @@ public function test_export_userkeys_basic_key() {
 
         provider::export_userkeys($context, $subcontext, 'core_tests');
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertTrue($writer->has_any_data());
@@ -107,6 +108,7 @@ public function test_export_userkeys_complex_key() {
         // Export all keys in core_tests.
         provider::export_userkeys($context, $subcontext, 'core_tests');
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertTrue($writer->has_any_data());
@@ -143,6 +145,7 @@ public function test_export_userkeys_basic_key_without_filter() {
 
         provider::export_userkeys($context, $subcontext, 'core_tests');
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertTrue($writer->has_any_data());
@@ -179,11 +182,13 @@ public function test_export_userkeys_complex_key_with_filter() {
 
         // Export all keys in core_tests against instance 43 - no keys.
         provider::export_userkeys($context, $subcontext, 'core_tests', 43);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
 
         // Export all keys in core_tests against instance 42.
         provider::export_userkeys($context, $subcontext, 'core_tests', 42);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $exported = $writer->get_related_data($subcontext, 'userkeys');
@@ -224,11 +229,13 @@ public function test_export_userkeys_multiple_complex_key_with_filter() {
 
         // Export all keys in core_tests against instance 43 - no keys.
         provider::export_userkeys($context, $subcontext, 'core_tests', 43);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
 
         // Export all keys in core_tests against instance 42.
         provider::export_userkeys($context, $subcontext, 'core_tests', 42);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $exported = $writer->get_related_data($subcontext, 'userkeys');
@@ -278,11 +285,13 @@ public function test_export_userkeys_multiple_users() {
 
         // Export all keys in core_tests against instance 43 - no keys.
         provider::export_userkeys($context, $subcontext, 'core_tests', 43);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
 
         // Export all keys in core_tests against instance 42.
         provider::export_userkeys($context, $subcontext, 'core_tests', 42);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $exported = $writer->get_related_data($subcontext, 'userkeys');

mod/assign/tests/privacy/provider_test.php

@@ -299,6 +299,7 @@ public function test_export_user_data_student() {
         // Give the submission a grade.
         $assign->save_grade($user->id, $data);
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
 
@@ -411,6 +412,7 @@ public function test_export_user_data_teacher() {
         $flagdata->extensionduedate = $duedate;
         $assign->update_user_flags($flagdata);
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
 

mod/quiz/accessrule/seb/tests/privacy/provider_test.php

@@ -119,6 +119,7 @@ public function test_export_user_data() {
         );
 
         writer::reset();
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data());
         provider::export_user_data($approvedcontextlist);

mod/quiz/tests/privacy/provider_test.php

@@ -170,6 +170,7 @@ public function test_user_with_data() {
         provider::export_user_data($approvedcontextlist);
 
         // Ensure that the quiz data was exported correctly.
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
 
@@ -366,6 +367,7 @@ public function test_wrong_context() {
         provider::export_user_data($approvedcontextlist);
 
         // Ensure that nothing was exported.
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertFalse($writer->has_any_data_in_any_context());
 

mod/scorm/report/basic/tests/privacy/provider_test.php

@@ -68,6 +68,7 @@ public function test_export_user_preferences_single() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('scormreport_basic');

mod/scorm/report/interactions/tests/privacy/provider_test.php

@@ -71,6 +71,7 @@ public function test_export_user_preferences_single() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('scormreport_interactions');

mod/scorm/report/objectives/tests/privacy/provider_test.php

@@ -68,6 +68,7 @@ public function test_export_user_preferences_single() {
         // Validate exported data.
         provider::export_user_preferences($user->id);
         $context = \context_user::instance($user->id);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
         $this->assertTrue($writer->has_any_data());
         $prefs = $writer->get_user_preferences('scormreport_objectives');

notes/tests/privacy/provider_test.php

@@ -229,6 +229,7 @@ public function test_export_user_data() {
         foreach ($contextlist as $context) {
             $this->assertEquals(CONTEXT_COURSE, $context->contextlevel);
 
+            /** @var \core_privacy\tests\request\content_writer $writer */
             $writer = writer::with_context($context);
             $this->assertTrue($writer->has_any_data());
         }

question/tests/privacy/provider_test.php

@@ -96,6 +96,7 @@ public function test_export_question_usage_no_usage() {
         $options = new \question_display_options();
 
         provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, false);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertFalse($writer->has_any_data_in_any_context());
@@ -137,6 +138,7 @@ public function test_export_question_usage_with_usage() {
         // Export all questions for this attempt.
         $options = new \question_display_options();
         provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, true);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertTrue($writer->has_any_data_in_any_context());
@@ -161,6 +163,7 @@ public function test_export_question_usage_with_usage() {
         $options->marks = \question_display_options::HIDDEN;
 
         provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, true);
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         $this->assertTrue($writer->has_any_data_in_any_context());

question/tests/privacy_helper.php

@@ -93,6 +93,7 @@ public function assert_question_attempt_exported(\context $context, array $subco
             [get_string('questions', 'core_question')]
         );
 
+        /** @var \core_privacy\tests\request\content_writer $writer */
         $writer = writer::with_context($context);
 
         foreach ($quba->get_slots() as $slotno) {