[firebase_core, firebase_analytics, firebase_crashlytics] fix overrid…

…es a deprecated API (firebase#1886) * ignore .flutter-plugins-dependencies * Core, Analytics, Crashlytics fix uses or overrides a deprecated API * update pubspec.yaml and CHANGELOG.md
ahmedkheikal · Jan 31, 2020 · e1523ab · e1523ab
1 parent 32a8126
commit e1523ab
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -36,6 +36,7 @@ GeneratedPluginRegistrant.m
 GeneratedPluginRegistrant.java
 build/
 .flutter-plugins
+.flutter-plugins-dependencies
 
 .project
 .classpath

diff --git a/packages/firebase_analytics/firebase_analytics/CHANGELOG.md b/packages/firebase_analytics/firebase_analytics/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 5.0.11
+
+* Fix overrides a deprecated API.
+* Raise minimum required Flutter SDK version to 1.12.13+hotfix.4
+
 ## 5.0.10
 
 * Keep a local registrar to get activity for foreground actions for v1 embedder.

diff --git a/...s/android/src/main/java/io/flutter/plugins/firebaseanalytics/FirebaseAnalyticsPlugin.java b/...s/android/src/main/java/io/flutter/plugins/firebaseanalytics/FirebaseAnalyticsPlugin.java
@@ -43,8 +43,7 @@ private Activity getActivity() {
 
   @Override
   public void onAttachedToEngine(@NonNull FlutterPluginBinding binding) {
-    onAttachedToEngine(
-        binding.getApplicationContext(), binding.getFlutterEngine().getDartExecutor());
+    onAttachedToEngine(binding.getApplicationContext(), binding.getBinaryMessenger());
   }
 
   private void onAttachedToEngine(Context applicationContext, BinaryMessenger binaryMessenger) {

diff --git a/packages/firebase_analytics/firebase_analytics/pubspec.yaml b/packages/firebase_analytics/firebase_analytics/pubspec.yaml
@@ -2,7 +2,7 @@ name: firebase_analytics
 description: Flutter plugin for Google Analytics for Firebase, an app measurement
   solution that provides insight on app usage and user engagement on Android and iOS.
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_analytics/firebase_analytics
-version: 5.0.10
+version: 5.0.11
 
 flutter:
   plugin:
@@ -29,4 +29,4 @@ dev_dependencies:
 
 environment:
   sdk: ">=2.0.0-dev.28.0 <3.0.0"
-  flutter: ">=1.10.0 <2.0.0"
+  flutter: ">=1.12.13+hotfix.4 <2.0.0"
diff --git a/packages/firebase_core/firebase_core/CHANGELOG.md b/packages/firebase_core/firebase_core/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.4.3+3
+
+* Fix overrides a deprecated API.
+
 ## 0.4.3+2
 
 * Add integration instructions for the `web` platform.

diff --git a/...ebase_core/android/src/main/java/io/flutter/plugins/firebase/core/FirebaseCorePlugin.java b/...ebase_core/android/src/main/java/io/flutter/plugins/firebase/core/FirebaseCorePlugin.java
@@ -52,7 +52,7 @@ private FirebaseCorePlugin(Context applicationContext) {
   @Override
   public void onAttachedToEngine(FlutterPluginBinding binding) {
     applicationContext = binding.getApplicationContext();
-    channel = new MethodChannel(binding.getFlutterEngine().getDartExecutor(), CHANNEL_NAME);
+    channel = new MethodChannel(binding.getBinaryMessenger(), CHANNEL_NAME);
     channel.setMethodCallHandler(this);
   }
 

diff --git a/packages/firebase_core/firebase_core/pubspec.yaml b/packages/firebase_core/firebase_core/pubspec.yaml
@@ -2,7 +2,7 @@ name: firebase_core
 description: Flutter plugin for Firebase Core, enabling connecting to multiple
   Firebase apps.
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_core/firebase_core
-version: 0.4.3+2
+version: 0.4.3+3
 
 flutter:
   plugin:

diff --git a/packages/firebase_crashlytics/CHANGELOG.md b/packages/firebase_crashlytics/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.1.2+5
+
+* Fix overrides a deprecated API.
+* Raise minimum required Flutter SDK version to 1.12.13+hotfix.4
+
 ## 0.1.2+4
 
 * Updated the example with the missing `recordError()` method.

diff --git a/...o/flutter/plugins/firebase/crashlytics/firebasecrashlytics/FirebaseCrashlyticsPlugin.java b/...o/flutter/plugins/firebase/crashlytics/firebasecrashlytics/FirebaseCrashlyticsPlugin.java
@@ -26,7 +26,7 @@ public class FirebaseCrashlyticsPlugin implements FlutterPlugin, MethodCallHandl
 
   @Override
   public void onAttachedToEngine(FlutterPluginBinding binding) {
-    BinaryMessenger binaryMessenger = binding.getFlutterEngine().getDartExecutor();
+    BinaryMessenger binaryMessenger = binding.getBinaryMessenger();
     channel = setup(binaryMessenger, binding.getApplicationContext());
   }
 

diff --git a/packages/firebase_crashlytics/pubspec.yaml b/packages/firebase_crashlytics/pubspec.yaml
@@ -2,12 +2,12 @@ name: firebase_crashlytics
 description:
   Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
   Firebase console.
-version: 0.1.2+4
+version: 0.1.2+5
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_crashlytics
 
 environment:
   sdk: ">=2.0.0-dev.28.0 <3.0.0"
-  flutter: ">=1.10.0 <2.0.0"
+  flutter: ">=1.12.13+hotfix.4 <2.0.0"
 
 dependencies:
   flutter: