Merge pull request consolidation#154 from aaukt/errorhandler

use custom error handler to correctly handle errors that were suppressed...

src/Runner.php

@@ -49,6 +49,7 @@ protected function loadRoboFile()
     public function execute($input = null)
     {
         register_shutdown_function(array($this, 'shutdown'));
+        set_error_handler(array($this, 'handleError'));
         Config::setOutput(new ConsoleOutput());
         $input = $this->prepareInput($input ? $input : $_SERVER['argv']);
 
@@ -163,5 +164,20 @@ public function shutdown()
         if (!is_array($error)) return;
         $this->writeln(sprintf("<error>ERROR: %s \nin %s:%d\n</error>", $error['message'], $error['file'], $error['line']));
     }
+
+    /**
+     * This is just a proxy error handler that checks the current error_reporting level.
+     * In case error_reporting is disabled the error is marked as handled, otherwise
+     * the normal internal error handling resumes.
+     *
+     * @return bool
+     */
+    public function handleError()
+    {
+        if (error_reporting() === 0) {
+            return true;
+        }
+        return false;
+    }
 }
 

tests/unit/RunnerTest.php

@@ -94,6 +94,33 @@ public function testCommandNaming()
         $this->assertNotNull($this->app->find('generate:user-avatar'));
     }
 
+    public function testHandleError()
+    {
+        $tmpLevel = error_reporting();
+
+        $this->assertFalse($this->runner->handleError());
+        error_reporting(0);
+        $this->assertTrue($this->runner->handleError());
+
+        error_reporting($tmpLevel);
+    }
+
+    public function testErrorIsHandled()
+    {
+        $tmpLevel = error_reporting();
+
+        error_reporting(E_USER_ERROR);
+        set_error_handler(array($this->runner, 'handleError'));
+        @trigger_error('test error', E_USER_ERROR);
+        $this->assertEmpty(error_get_last());
+
+        error_reporting(0);
+        trigger_error('test error', E_USER_ERROR);
+        $this->assertEmpty(error_get_last());
+
+        error_reporting($tmpLevel);
+    }
+
     protected function createCommand($name)
     {
         return $this->runner->createCommand(new \Robo\TaskInfo(self::ROBOFILE, $name));