Flush pending graphics commands when the unref queue is drained on th…

…e IO thread (flutter#44831) See flutter/flutter#131524
aholza · Aug 18, 2023 · 6ceebc9 · 6ceebc9
1 parent 72c4e61
commit 6ceebc9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/flow/skia_gpu_object.h b/flow/skia_gpu_object.h
@@ -128,6 +128,8 @@ class UnrefQueue : public fml::RefCountedThreadSafe<UnrefQueue<T>> {
       if (!skia_objects.empty()) {
         context->performDeferredCleanup(std::chrono::milliseconds(0));
       }
+
+      context->flushAndSubmit(true);
     }
   }
 

diff --git a/flow/skia_gpu_object_unittests.cc b/flow/skia_gpu_object_unittests.cc
@@ -43,6 +43,7 @@ class TestResourceContext : public TestSkObject {
   ~TestResourceContext() = default;
   void performDeferredCleanup(std::chrono::milliseconds msNotUsed) {}
   void deleteBackendTexture(const GrBackendTexture& texture) {}
+  void flushAndSubmit(bool syncCpu) {}
 };
 
 class SkiaGpuObjectTest : public ThreadTest {
-Original file line number
+Diff line change
@@ Expand Up @@
           if (!skia_objects.empty()) {
             context->performDeferredCleanup(std::chrono::milliseconds(0));
           }
+          context->flushAndSubmit(true);
         }
       }
@@ Expand Down @@