Add ShellCheck's --enable=all inside scripts/

Strengthen static code analysis for shell scripts. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12914
aidanharris · Jan 13, 2022 · 8361369 · 8361369
1 parent 8a7c4ef
commit 8361369
Show file tree

Hide file tree

Showing 10 changed files with 105 additions and 81 deletions.
diff --git a/scripts/Makefile.am b/scripts/Makefile.am
@@ -28,6 +28,7 @@ EXTRA_DIST = \
 	$(EXTRA_SCRIPTS)
 
 SHELLCHECKSCRIPTS = $(EXTRA_SCRIPTS)
+SHELLCHECK_OPTS = --enable=all
 
 define EXTRA_ENVIRONMENT
 

diff --git a/scripts/commitcheck.sh b/scripts/commitcheck.sh
@@ -51,7 +51,7 @@ new_change_commit()
         error=1
     fi
 
-    return $error
+    return "$error"
 }
 
 is_coverity_fix()
@@ -99,7 +99,7 @@ coverity_fix_commit()
         error=1
     fi
 
-    return $error
+    return "$error"
 }
 
 if [ -n "$1" ]; then