tweak barGrid

aihua · Jan 6, 2017 · 3d9ff46 · 3d9ff46
1 parent 62f1247
commit 3d9ff46
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/chart/bar/PictorialBarSeries.js b/src/chart/bar/PictorialBarSeries.js
@@ -25,6 +25,8 @@ define(function(require) {
             symbolBoundingData: null,
             symbolPatternSize: 400, // 400 * 400 px
 
+            barGap: '-100%',      // In most case, overlap is needed.
+
             // z can be set in data item, which is z2 actually.
 
             // Disable progressive

diff --git a/src/layout/barGrid.js b/src/layout/barGrid.js
@@ -57,6 +57,12 @@ define(function(require) {
             );
             var barGap = seriesModel.get('barGap');
             var barCategoryGap = seriesModel.get('barCategoryGap');
+
+            // Caution: In a single coordinate system, these barGrid attributes
+            // will be shared by series. Consider that they have default values,
+            // only the attributes set on the last series will work.
+            // Do not change this fact unless there will be a break change.
+
             // TODO
             if (barWidth && !stacks[stackId].width) {
                 barWidth = Math.min(columnsOnAxis.remainedWidth, barWidth);