Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDE warnings, specially some related to generics #1

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Jun 16, 2017

Found with Eclipse. Did not "organise imports" as that would generate a much bigger diff with no reason. Tests failing with several NPE, but I think it's due to some current changes in the code?

Thanks
Bruno

@aika-algorithm aika-algorithm merged commit 18e0518 into aika-algorithm:master Jun 16, 2017
@aika-algorithm
Copy link
Owner

Hi Bruno,
thank you very much for those fixes! Yes, it's been a while since the last "organize imports" so I've now commited that. :-) But with the NPE's that's strange. That should not be the case. I'm using IntelliJ and i can run the tests without any of them failing. However, some are set to ignore. Even when I run the tests in maven everything seems to be in order. I have no idea. Could you have a look at it or see if you can give me a hint?

Thanks
Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants