fix: notify api returns internal error on malformed id (awslabs#885)

aim-ahead · Jan 26, 2022 · fa2550c · fa2550c
1 parent e319bdb
commit fa2550c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/addons/addon-base-raas/packages/base-raas-services/lib/data-egress/data-egress-service.js b/addons/addon-base-raas/packages/base-raas-services/lib/data-egress/data-egress-service.js
@@ -312,6 +312,9 @@ class DataEgressService extends Service {
     }
 
     const egressStoreInfo = await this.getEgressStoreInfo(environmentId);
+    if (!egressStoreInfo) {
+      throw this.boom.notFound(`Error: egress store info not found for environment ${environmentId}!`, true);
+    }
     const isEgressStoreOwner = egressStoreInfo.createdBy === curUser;
     if (!isAdmin(requestContext) && !isEgressStoreOwner) {
       throw this.boom.forbidden(