Fix timeout-related issues in tuners #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Я еще посмотрю, возможно похожие проблемы имеется и в других тюнерах (как минимум в IOptTuner небольшой timeout вызывает ошибку) |
Lopa10ko
reviewed
Feb 21, 2025
| @@ -46,6 +46,7 @@ def _tune(self, graph: DomainGraphForTune, **kwargs) -> DomainGraphForTune: | |||
| Args: | |||
| graph: graph which hyperparameters will be tuned | |||
| """ | |||
| final_graph = deepcopy(self.init_graph) | |||
There was a problem hiding this comment.
nit: есть ли смысл использовать проперти init_graph?
можно посмотреть на tune в BaseTuner и убедиться, что во вложенный метод _tune прокидывается граф, поэтому здесь будет достаточно в final_graph положить указатель на graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #280