Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement monorepo #7

Merged
merged 41 commits into from
Apr 11, 2024
Merged

Implement monorepo #7

merged 41 commits into from
Apr 11, 2024

Conversation

airone01
Copy link
Owner

@airone01 airone01 commented Apr 3, 2024

Resolves #6

@airone01 airone01 linked an issue Apr 3, 2024 that may be closed by this pull request
0n0 monorepo #6
Closed
3 tasks
airone01 added 2 commits April 8, 2024 22:13
@airone01
chore(configs): move tailwind and postcss configs to @0n0/tailwind-co…
a03c0d0 
…nfig
@airone01
docs(changeset): move all general components to @0n0/ui
f343330 
Move all "general"-purpose UI components to `@0n0/ui`, to centralize them for use when making a new
web app.

BREAKING CHANGE: General-purpose components will now have to be called via `@0n0/ui`. Don't forget
to add the dep (`"@0n0/ui": "workspace:*"`) to `package.json`.

fix #6
@airone01
Copy link
Owner Author

airone01 commented Apr 8, 2024 •
edited
Loading

With f343330, the "general"-purpose components (mainly the ones from shadcn/ui), will be moved to the @0n0/ui package, rather than having duplicates in every application (at the time of writing, just @0n0/converter).

For future apps, classical monorepo behavior is expected, which means importing the UI package ("@0n0/ui": "workspace:*" in the dependencies array in package.json, and e.g., import {Button} from '@0n0/ui/button';).

Breaking change because this is the actual main change in the repo when transitioning to a monorepo.
changeset has been updated. Need to update the changelog as well after merging.

@airone01 airone01 mentioned this pull request Apr 8, 2024
Closed
3 tasks
Repository owner deleted a comment from vercel bot Apr 9, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
converter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:35am

@airone01 airone01 merged commit 3d5e8fc into main Apr 11, 2024
6 checks passed
@airone01
Copy link
Owner Author

Just realized this has been merged to main, not dev. Whoops.

@airone01 airone01 deleted the feat/monorepo branch April 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0n0 monorepo
1 participant
@airone01