fix(webpack): Fixed libraryTarget option not being set for node targe…

…ts (nrwl#20505)
aisflat439 · Dec 4, 2023 · a08fdf0 · a08fdf0
1 parent 43a4482
commit a08fdf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/e2e/node/src/node-webpack.test.ts b/e2e/node/src/node-webpack.test.ts
@@ -52,7 +52,7 @@ describe('Node Applications + webpack', () => {
 
     await runCLIAsync(`build ${app} --optimization`);
     const optimizedContent = readFile(`dist/apps/${app}/main.js`);
-    expect(optimizedContent).toContain('console.log("foo bar")');
+    expect(optimizedContent).toContain('console.log("foo "+"bar")');
 
     // Test that serve can re-run dependency builds.
     const lib = uniq('nodelib');

diff --git a/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts b/packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts
@@ -95,6 +95,11 @@ function applyNxIndependentConfig(
 
   config.output = {
     ...config.output,
+    libraryTarget:
+      (config as Configuration).output?.libraryTarget ??
+      options.target === 'node'
+        ? 'commonjs'
+        : undefined,
     path:
       config.output?.path ??
       (options.outputPath