Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postman 21 export #1

Open
wants to merge 349 commits into
base: postman-21-export
Choose a base branch
from
Open

Postman 21 export #1

wants to merge 349 commits into from

Conversation

jfbloom22
Copy link

Description

  • merged in the latest from upstream and resolved merge conflicts
  • fixed: parsing the hopscotch URL with environment variable for the domain was failing since it was not a properly formatted URL.
  • I was able to export out my collection of 80 requests and import them into Postman.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

One test failed, but it is also failing for me on main branch.

 FAIL src/auth/auth.service.spec.ts (9.072 s)
│   ● verifyMagicLinkTokens › Should throw MAGIC_LINK_EXPIRED if passwordless token is expired
│     TypeError: Cannot read properties of undefined (reading '_tag')

balub and others added 30 commits January 19, 2023 05:53
@balub
chore: made the required changes in auth and user modules to accommod…
c38ad89 
…ate changes made in user schema
@ankitsridhar16
chore: added review changes for description
6aa66e9
@ankitsridhar16
chore: added review changes for updating mutations and naming for des…
3e9295f 
…criptions
@ankitsridhar16
chore: updated comment for Subscription Type and updated JSDoc for pu…
4aad8d3 
…blish
@ankitsridhar16
chore: updated test cases with requested changes to handle publishing…
d10ed66 
… seperately
@ankitsridhar16
chore: introduced subscription handler and fixed requested review cha…
0a469f4 
…nges
@balub
refactor: logout route now just returning 200 status code not redirec…
53571a7 
…ting to app_domain
@ankitsridhar16
chore: updated module type name
2252048
@ankitsridhar16
chore: made review changes
86aa025
@ankitsridhar16
chore: made review changes for resolvers and introduced stringToJson …
669f8b0 
…from user-settings
@ankitsridhar16
chore: introduced string to json from user-settings and moved types
f6f4547
@ankitsridhar16
chore: updated ts config with review changes
ca5404a
@mirarifhasan
fix: keeping timestamp without timezone
08ac968
@balub
chore: cleaned unwanted imports in auth module
5096048
@balub
fix: changed return type of deleteUserEnvironment mutation to boolean…
8929b37 
… in user-environments resolver
@balub
refactor: changed the return type of deleteUserEnvironments method to…
da9fcd1 
… number from void
@balub
fix: changed the return type of delete many subscription to number fr…
cde0ba1 
…om user-environment type
@balub
Merge pull request hoppscotch#3 from hoppscotch/feat/user-environments
60e2ef7 
feat: introduce user environments in self hosted
@balub
chore: replaced hardcoded values with env variables in app.module.ts,…
a6ad86b 
… main.ts and utils.ts
@balub
fix: fixed magic-link account creation bug
b238f3d
@balub
test: wrote tests for user service file
f79070f
@ankitsridhar16
chore: added message types to PubSub Service
a0006f7
@ankitsridhar16
chore: updated user environment to use PubSub instead of Subscription…
bc55af2 
…Handler
@ankitsridhar16
chore: removed subscription handler related files
0bed5cd
@balub
chore: updated .env.example file with new data
ee3fbab
@ankitsridhar16
chore: removed comment
298b960
@ankitsridhar16
chore: updated types to def and changed deleted many as a new indexed…
6da85fd 
… type
@ankitsridhar16
chore: removed the logic for primitiveTypes as it is unused
606e012
@balub
test: wrote tests for auth service file
96ed2f2
@balub
chore: user displayName and photoURL property updates itself when fou…
b2acd55 
…nd with SSO providers
AndrewBastin and others added 27 commits April 9, 2023 22:52
@AndrewBastin
chore: run vite and gql-codegen in parallel on selfhost-web dev mode
e88e6a7
@AndrewBastin
chore: update CODEOWNERS file
8e25598
@balub
chore: added global lint and test commands to backend package (hoppsc…
4ce9e67 
…otch#81)

* chore: added global lint and test commands to backend package

* chore: removed lint command from root scope execution
@JoelJacobStephen
fix: changed vite icon to hoppscotch icon and changed title in admin …
c4358b9 
…dashboard (hoppscotch#82)
@AndrewBastin
chore: update ci actions
61b9aca
@amk-dev @AndrewBastin
chore: changes to support id based syncing for collections (hoppscotc…
eeee8af 
…h#2977)
@AndrewBastin
chore: merge central/staging into self-hosted/main
5d1337f
@amk-dev
refactor: refactor collection to not use mapper (hoppscotch#80)
c353d60
@AndrewBastin
refactor: change user collections min title length to 1
b68115d
@AndrewBastin
chore: remove hoppscotch-web from self-hosted
a8f0a8a
@AndrewBastin
chore: update README
1b1c02c
@balub
fix: fixed incorrect GOOGLE_SCOPE env value in .env.example file (hop…
4806499 
…pscotch#2983)
@liyasthomas
docs: updated screenshots (hoppscotch#2984)
eab4893
@liyasthomas
docs: fixed broken documentation links (hoppscotch#2997)
5d8b55e
@liyasthomas
docs: added border to screenshots (hoppscotch#2987)
4ada31b
@liyasthomas
i18n: updated locales to reflect latest strings (hoppscotch#2989)
bd09a6a
@liyasthomas
fix: unwanted transitions caused pane layout shift (hoppscotch#2988)
d6c706d
@liyasthomas
chore: improve tabs scrollbar & unsaved request indicator (hoppscotch…
80da790 
…#3003)
@liyasthomas
chore: use auto-imported icons (hoppscotch#2998)
b42a94e
@nivedin
fix: selected env changed while sidebar collapsed (hoppscotch#3002)
3506e96
@liyasthomas
fix: non-prettified output on large JSON objects (hoppscotch#3008)
c1f4855
@anwarulislam @AndrewBastin
fix: language switching issue to en from slug (hoppscotch#3006)
4acc4b2 
Co-authored-by: Andrew Bastin <[email protected]>
@nivedin
fix: request name not updating in the save request modal (hoppscotch#…
522de45 
…3010)
@anwarulislam
fix: wrong tab selected after navigating from different route (hoppsc…
41fa3b5 
…otch#3012)
@AndrewBastin
chore: release 2023.4.1
8450fb6
@jfbloom22
Merge github.com:hoppscotch/hoppscotch into postman-21-export
c2d4f07
@jfbloom22
fix: issues with parsing hopscotch urls. Successfully exporting and i…
b75896b 
…mporting into Postman
@jfbloom22 jfbloom22 requested a review from aitchnyu as a code owner May 6, 2023 19:06
@jfbloom22
Copy link
Author

@aitchnyu I am happy to help get this export to postman feature merged in.

This is one of my first contributions to open source. I am not sure if I opened this PR the best way. If it would be better for me to open it directly on the postman repo, just let me know.

@jfbloom22 jfbloom22 mentioned this pull request May 7, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitchnyu aitchnyu Awaiting requested review from aitchnyu aitchnyu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jfbloom22 @balub @ankitsridhar16 @mirarifhasan @AndrewBastin @amk-dev @nivedin @JoelJacobStephen @liyasthomas @anwarulislam