Skip to content

Commit

Permalink
Unexpose subclasses of ResourceFormatLoader and -Saver
Browse files Browse the repository at this point in the history
ResourceFormatLoader and ResourceFormatSaver are meant to be overridden
to add support for different formats in ResourceLoader and ResourceSaver.
Those should be exposed as they can be overridden in plugins.

On the other hand, all predefined subclasses of those two base classes
are only meant to register support for new file and resource types, but
should not and cannot be used directly from script, so they should not
be exposed.

Also unexposed ResourceImporterOGGVorbis (and thus its base class
ResourceImporter) which are editor-only.
  • Loading branch information
akien-mga committed Jun 18, 2019
1 parent 054ac5c commit d6176db
Show file tree
Hide file tree
Showing 59 changed files with 10 additions and 422 deletions.
1 change: 0 additions & 1 deletion core/io/image_loader.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ class ImageLoader {
};

class ResourceFormatLoaderImage : public ResourceFormatLoader {
GDCLASS(ResourceFormatLoaderImage, ResourceFormatLoader)
public:
virtual RES load(const String &p_path, const String &p_original_path = "", Error *r_error = NULL);
virtual void get_recognized_extensions(List<String> *p_extensions) const;
Expand Down
2 changes: 0 additions & 2 deletions core/io/resource_format_binary.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ class ResourceInteractiveLoaderBinary : public ResourceInteractiveLoader {
};

class ResourceFormatLoaderBinary : public ResourceFormatLoader {
GDCLASS(ResourceFormatLoaderBinary, ResourceFormatLoader)
public:
virtual Ref<ResourceInteractiveLoader> load_interactive(const String &p_path, const String &p_original_path = "", Error *r_error = NULL);
virtual void get_recognized_extensions_for_type(const String &p_type, List<String> *p_extensions) const;
Expand Down Expand Up @@ -162,7 +161,6 @@ class ResourceFormatSaverBinaryInstance {
};

class ResourceFormatSaverBinary : public ResourceFormatSaver {
GDCLASS(ResourceFormatSaverBinary, ResourceFormatSaver)
public:
static ResourceFormatSaverBinary *singleton;
virtual Error save(const String &p_path, const RES &p_resource, uint32_t p_flags = 0);
Expand Down
2 changes: 0 additions & 2 deletions core/io/resource_importer.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class ResourceImporter;

class ResourceFormatImporter : public ResourceFormatLoader {

GDCLASS(ResourceFormatImporter, ResourceFormatLoader)

struct PathAndType {
String path;
String type;
Expand Down
1 change: 0 additions & 1 deletion core/io/translation_loader_po.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include "core/translation.h"

class TranslationLoaderPO : public ResourceFormatLoader {
GDCLASS(TranslationLoaderPO, ResourceFormatLoader)
public:
static RES load_translation(FileAccess *f, Error *r_error, const String &p_path = String());
virtual RES load(const String &p_path, const String &p_original_path = "", Error *r_error = NULL);
Expand Down
13 changes: 0 additions & 13 deletions doc/classes/GDNativeLibraryResourceLoader.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/GDNativeLibraryResourceSaver.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatDDS.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatImporter.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderBMFont.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderBinary.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderDynamicFont.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderGDScript.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderImage.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderNativeScript.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderShader.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderStreamTexture.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderText.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderTextureLayered.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderTheora.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatLoaderWebm.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatPKM.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatPVR.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatSaverBinary.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatSaverGDScript.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatSaverNativeScript.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatSaverShader.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceFormatSaverText.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceImporter.xml

This file was deleted.

13 changes: 0 additions & 13 deletions doc/classes/ResourceSaverPNG.xml

This file was deleted.

Loading

0 comments on commit d6176db

Please sign in to comment.