Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor textual fixes #83

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

burggraaff
Copy link
Contributor

Some very minor textual fixes I made while reading through the documentation.

  • Fixed typos, capitalisation, punctuation in docs.
  • Fixed typos, capitalisation, punctuation in docstrings and comments.
  • Fixed typos in Exception/Error messages.
  • Removed a reference to a CABOFileReader.get_header() method that doesn't exist.
  • Updated reference to new NASA Power website.
  • Updated examples in documentation to Python 3's print() function.
  • Whitespace improvements (done automatically by my IDE).

@burggraaff
Copy link
Contributor Author

burggraaff commented Mar 7, 2024

Incidentally and unrelated to the PR, while reading doc/index.rst, I saw that it mentions PCSE running in Python 2.7+ and 3.2+. Is this still accurate? For example, some modules use f-strings, which were introduced in Python 3.6. Do you intend to maintain such extensive backwards compatibility in the future, or is this simply an outdated description?

@ajwdewit
Copy link
Owner

Dear Burggraaf, this merge runs into conflicts. I will have a look at it later. python 2.7 and older 3.2 versions are not supported anymore, so I will update the documentation. The only limitation I have is that some people use PCSE together with IronPython which is now available for python 3.4 (was 2.7). Nevertheless, I need to remove a lot of stuff from PCSE anyway before it runs under IronPython.

@burggraaff
Copy link
Contributor Author

@ajwdewit I have resolved the conflicts and it should merge properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants