Check more target triples with cargo deny (emilk#2919)

akahan · Apr 18, 2023 · 93ee554 · 93ee554
1 parent 4809747
commit 93ee554
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -171,10 +171,16 @@ jobs:
         include:
           - target: aarch64-apple-darwin
           - target: aarch64-linux-android
+          - target: i686-pc-windows-gnu
+          - target: i686-pc-windows-msvc
+          - target: i686-unknown-linux-gnu
           - target: wasm32-unknown-unknown
+          - target: x86_64-apple-darwin
+          - target: x86_64-pc-windows-gnu
           - target: x86_64-pc-windows-msvc
           - target: x86_64-unknown-linux-gnu
-          # - target: x86_64-unknown-linux-musl
+          - target: x86_64-unknown-linux-musl
+          - target: x86_64-unknown-redox
 
     name: cargo-deny ${{ matrix.target }}
     runs-on: ubuntu-22.04

diff --git a/deny.toml b/deny.toml
@@ -1,13 +1,19 @@
 # https://embarkstudios.github.io/cargo-deny/
 
+# Note: running just `cargo deny check` without a `--target` can result in
+# false positives due to https://github.com/EmbarkStudios/cargo-deny/issues/324
 targets = [
     { triple = "aarch64-apple-darwin" },
-    { triple = "aarch64-linux-android" },
+    { triple = "i686-pc-windows-gnu" },
+    { triple = "i686-pc-windows-msvc" },
+    { triple = "i686-unknown-linux-gnu" },
     { triple = "wasm32-unknown-unknown" },
     { triple = "x86_64-apple-darwin" },
+    { triple = "x86_64-pc-windows-gnu" },
     { triple = "x86_64-pc-windows-msvc" },
     { triple = "x86_64-unknown-linux-gnu" },
     { triple = "x86_64-unknown-linux-musl" },
+    { triple = "x86_64-unknown-redox" },
 ]
 
 [advisories]
@@ -34,6 +40,7 @@ skip = [
     { name = "arrayvec" },            # old version via tiny-skiaz
     { name = "hashbrown" },           # old version via dark-light
     { name = "nix" },                 # old version via winit
+    { name = "redox_syscall" },       # old version via winit
     { name = "time" },                # old version pulled in by unmaintianed crate 'chrono'
     { name = "tiny-skia" },           # winit uses a different version from egui_extras (TODO(emilk): update egui_extras!)
     { name = "ttf-parser" },          # different versions pulled in by ab_glyph and usvg

diff --git a/sh/cargo-deny.sh b/sh/cargo-deny.sh
@@ -7,9 +7,13 @@ set -x
 
 # cargo install cargo-deny
 cargo deny --all-features --log-level error --target aarch64-apple-darwin check
-cargo deny --all-features --log-level error --target aarch64-linux-android check
+cargo deny --all-features --log-level error --target i686-pc-windows-gnu check
+cargo deny --all-features --log-level error --target i686-pc-windows-msvc check
+cargo deny --all-features --log-level error --target i686-unknown-linux-gnu check
 cargo deny --all-features --log-level error --target wasm32-unknown-unknown check
 cargo deny --all-features --log-level error --target x86_64-apple-darwin check
+cargo deny --all-features --log-level error --target x86_64-pc-windows-gnu check
 cargo deny --all-features --log-level error --target x86_64-pc-windows-msvc check
 cargo deny --all-features --log-level error --target x86_64-unknown-linux-gnu check
 cargo deny --all-features --log-level error --target x86_64-unknown-linux-musl check
+cargo deny --all-features --log-level error --target x86_64-unknown-redox check