Make sure we correctly open multiple piped files

ake-forks · Dec 1, 2016 · 236bfc8 · 236bfc8
1 parent 62e4347
commit 236bfc8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/notes b/notes
@@ -47,10 +47,10 @@ new_note() {
 
 open_something() {
     if [[ -p /dev/stdin ]]; then
-        read note_names
+        read -d'\n' note_names
         while read note_name; do
             open_note "$note_name"
-        done <<< $note_names
+        done <<< "$note_names"
     else
         open $notes_dir
     fi

diff --git a/test/test-open.bats b/test/test-open.bats
@@ -42,4 +42,15 @@ notes="./notes"
 
   assert_success
   assert_output "Editing $NOTES_DIRECTORY/note.md"
+}
+
+@test "Opens multiple files passed by pipe if provided" {
+  touch $NOTES_DIRECTORY/note.md
+  touch $NOTES_DIRECTORY/note2.md
+
+  run bash -c "$notes find | $notes open"
+
+  assert_success
+  assert_line "Editing $NOTES_DIRECTORY/note.md"
+  assert_line "Editing $NOTES_DIRECTORY/note2.md"
 }