Skip to content

Commit

Permalink
RDMA/cxgb4: Fix retry with MPAv1 logic for MPAv2
Browse files Browse the repository at this point in the history
Fix logic so that we don't retry with MPAv1 once we have done that
already.  Otherwise, we end up retrying with MPAv1 even when its not
needed on getting peer aborts - and this could lead to kernel panic.

Signed-off-by: Kumar Sanghvi <[email protected]>
Signed-off-by: Roland Dreier <[email protected]>
  • Loading branch information
Kumar Sanghvi authored and rolandd committed Nov 28, 2011
1 parent c34c97a commit 01b225e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/infiniband/hw/cxgb4/cm.c
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,10 @@ static void send_mpa_req(struct c4iw_ep *ep, struct sk_buff *skb,
(mpa_rev_to_use == 2 ? MPA_ENHANCED_RDMA_CONN : 0);
mpa->private_data_size = htons(ep->plen);
mpa->revision = mpa_rev_to_use;
if (mpa_rev_to_use == 1)
if (mpa_rev_to_use == 1) {
ep->tried_with_mpa_v1 = 1;
ep->retry_with_mpa_v1 = 0;
}

if (mpa_rev_to_use == 2) {
mpa->private_data_size +=
Expand Down

0 comments on commit 01b225e

Please sign in to comment.