ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant …

…null check smatch analysis: fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info: redundant null check on msg_ctx->msg calling kfree() Cc: Dustin Kirkland <[email protected]> Cc: [email protected] Signed-off-by: Tim Gardner <[email protected]> Signed-off-by: Tyler Hicks <[email protected]>
akeromi · Feb 12, 2013 · 1101d58 · 1101d58
1 parent 3a46741
commit 1101d58
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
@@ -97,8 +97,7 @@ static void ecryptfs_msg_ctx_free_to_alloc(struct ecryptfs_msg_ctx *msg_ctx)
 void ecryptfs_msg_ctx_alloc_to_free(struct ecryptfs_msg_ctx *msg_ctx)
 {
 	list_move(&(msg_ctx->node), &ecryptfs_msg_ctx_free_list);
-	if (msg_ctx->msg)
-		kfree(msg_ctx->msg);
+	kfree(msg_ctx->msg);
 	msg_ctx->msg = NULL;
 	msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_FREE;
 }