Skip to content

Commit

Permalink
Remove pointless memset in nfsacl_encode()
Browse files Browse the repository at this point in the history
Remove pointless memset() in nfsacl_encode().

Thanks to Trond Myklebust <[email protected]> for pointing out
that it is not needed since posix_acl_init() will set everything
regardless..

Signed-off-by: Jesper Juhl <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
  • Loading branch information
jjuhl authored and Trond Myklebust committed Mar 23, 2011
1 parent 4667058 commit 51e8165
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/nfs_common/nfsacl.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode,
* invoked in contexts where a memory allocation failure is
* fatal. Fortunately this fake ACL is small enough to
* construct on the stack. */
memset(acl2, 0, sizeof(acl2));
posix_acl_init(acl2, 4);

/* Insert entries in canonical order: other orders seem
Expand Down

0 comments on commit 51e8165

Please sign in to comment.