Skip to content

Commit

Permalink
more low-hanging fruits - kernel, fs, lib signedness
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Oct 14, 2007
1 parent b4482a4 commit 5ba2533
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion fs/jfs/jfs_dtree.c
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ static void free_index(tid_t tid, struct inode *ip, u32 index, u32 next)
* Changes an entry in the directory index table
*/
static void modify_index(tid_t tid, struct inode *ip, u32 index, s64 bn,
int slot, struct metapage ** mp, u64 *lblock)
int slot, struct metapage ** mp, s64 *lblock)
{
struct dir_table_slot *dirtab_slot;

Expand Down
2 changes: 1 addition & 1 deletion fs/jfs/jfs_incore.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ struct jfs_inode_info {
short btorder; /* access order */
short btindex; /* btpage entry index*/
struct inode *ipimap; /* inode map */
long cflag; /* commit flags */
unsigned long cflag; /* commit flags */
u16 bxflag; /* xflag of pseudo buffer? */
unchar agno; /* ag number */
signed char active_ag; /* ag currently allocating from */
Expand Down
2 changes: 1 addition & 1 deletion fs/jfs/jfs_logmgr.h
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ struct jfs_log {
int size; /* 4: log size in log page (in page) */
int l2bsize; /* 4: log2 of bsize */

long flag; /* 4: flag */
unsigned long flag; /* 4: flag */

struct lbuf *lbuf_free; /* 4: free lbufs */
wait_queue_head_t free_wait; /* 4: */
Expand Down
2 changes: 1 addition & 1 deletion fs/smbfs/smbiod.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static LIST_HEAD(smb_servers);
static DEFINE_SPINLOCK(servers_lock);

#define SMBIOD_DATA_READY (1<<0)
static long smbiod_flags;
static unsigned long smbiod_flags;

static int smbiod(void *);
static int smbiod_start(void);
Expand Down
4 changes: 2 additions & 2 deletions include/linux/reiserfs_fs_sb.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ struct reiserfs_journal_cnode {
struct buffer_head *bh; /* real buffer head */
struct super_block *sb; /* dev of real buffer head */
__u32 blocknr; /* block number of real buffer head, == 0 when buffer on disk */
long state;
unsigned long state;
struct reiserfs_journal_list *jlist; /* journal list this cnode lives in */
struct reiserfs_journal_cnode *next; /* next in transaction list */
struct reiserfs_journal_cnode *prev; /* prev in transaction list */
Expand Down Expand Up @@ -181,7 +181,7 @@ struct reiserfs_journal {
struct block_device *j_dev_bd;
int j_1st_reserved_block; /* first block on s_dev of reserved area journal */

long j_state;
unsigned long j_state;
unsigned long j_trans_id;
unsigned long j_mount_id;
unsigned long j_start; /* start of current waiting commit (index into j_ap_blocks) */
Expand Down
6 changes: 3 additions & 3 deletions kernel/posix-timers.c
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ sys_timer_getoverrun(timer_t timer_id)
{
struct k_itimer *timr;
int overrun;
long flags;
unsigned long flags;

timr = lock_timer(timer_id, &flags);
if (!timr)
Expand Down Expand Up @@ -784,7 +784,7 @@ sys_timer_settime(timer_t timer_id, int flags,
struct k_itimer *timr;
struct itimerspec new_spec, old_spec;
int error = 0;
long flag;
unsigned long flag;
struct itimerspec *rtn = old_setting ? &old_spec : NULL;

if (!new_setting)
Expand Down Expand Up @@ -836,7 +836,7 @@ asmlinkage long
sys_timer_delete(timer_t timer_id)
{
struct k_itimer *timer;
long flags;
unsigned long flags;

retry_delete:
timer = lock_timer(timer_id, &flags);
Expand Down
2 changes: 1 addition & 1 deletion lib/idr.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
int n, m, sh;
struct idr_layer *p, *new;
int l, id, oid;
long bm;
unsigned long bm;

id = *starting_id;
restart:
Expand Down

0 comments on commit 5ba2533

Please sign in to comment.