Skip to content

Commit

Permalink
block: Remove redundant WARN_ON()
Browse files Browse the repository at this point in the history
Commit 2fff8a9 ("block: Check locking assumptions at runtime") added a
lockdep_assert_held(q->queue_lock) which makes the WARN_ON() redundant
because lockdep will detect and warn about context violations.

The unconditional WARN_ON() does not provide real additional value, so it
can be removed.

Signed-off-by: Anna-Maria Gleixner <[email protected]>
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
anna-marialx authored and axboe committed May 7, 2018
1 parent f3a1075 commit 656cb6d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ EXPORT_SYMBOL(blk_start_queue_async);
void blk_start_queue(struct request_queue *q)
{
lockdep_assert_held(q->queue_lock);
WARN_ON(!in_interrupt() && !irqs_disabled());
WARN_ON_ONCE(q->mq_ops);

queue_flag_clear(QUEUE_FLAG_STOPPED, q);
Expand Down

0 comments on commit 656cb6d

Please sign in to comment.