hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common()

We can't pass error pointers to kfree() or it causes an oops. Fixes: 52b209f ('get rid of hostfs_read_inode()') Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Richard Weinberger <[email protected]>
akeromi · Aug 3, 2016 · 8a545f1 · 8a545f1
1 parent 915eed2
commit 8a545f1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
@@ -959,10 +959,11 @@ static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent)
 
 	if (S_ISLNK(root_inode->i_mode)) {
 		char *name = follow_link(host_root_path);
-		if (IS_ERR(name))
+		if (IS_ERR(name)) {
 			err = PTR_ERR(name);
-		else
-			err = read_name(root_inode, name);
+			goto out_put;
+		}
+		err = read_name(root_inode, name);
 		kfree(name);
 		if (err)
 			goto out_put;