Skip to content

Commit

Permalink
autofs: remove possibly misleading /* #define DEBUG */
Browse files Browse the repository at this point in the history
Having this in autofs_i.h gives illusion that uncommenting this enables
pr_debug(), but it doesn't enable all the pr_debug() in autofs because
inclusion order matters.

XFS has the same DEBUG macro in its core header fs/xfs/xfs.h, however XFS
seems to have a rule to include this prior to other XFS headers as well as
kernel headers.  This is not the case with autofs, and DEBUG could be
enabled via Makefile, so autofs should just get rid of this comment to
make the code less confusing.  It's a comment, so there is literally no
functional difference.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Tomohiro Kusumi <[email protected]>
Signed-off-by: Ian Kent <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
kusumi authored and torvalds committed Oct 11, 2016
1 parent 9b88ee0 commit 962ca7c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/autofs4/autofs_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
#include <asm/current.h>
#include <linux/uaccess.h>

/* #define DEBUG */

#ifdef pr_fmt
#undef pr_fmt
#endif
Expand Down

0 comments on commit 962ca7c

Please sign in to comment.