Skip to content

Commit

Permalink
mac80211: ethtool: memset the whole sinfo struct to 0
Browse files Browse the repository at this point in the history
Rather than just setting the valid flags to 0 set the
whole struct to 0 since other places might rely on it.

Signed-off-by: Johannes Berg <[email protected]>
  • Loading branch information
jmberg-intel committed May 7, 2018
1 parent 35f4962 commit bfb2781
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions net/mac80211/ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Copied from cfg.c - originally
* Copyright 2006-2010 Johannes Berg <[email protected]>
* Copyright 2014 Intel Corporation (Author: Johannes Berg)
* Copyright (C) 2018 Intel Corporation
*
* This file is GPLv2 as found in COPYING.
*/
Expand Down Expand Up @@ -106,7 +107,7 @@ static void ieee80211_get_stats(struct net_device *dev,
if (!(sta && !WARN_ON(sta->sdata->dev != dev)))
goto do_survey;

sinfo.filled = 0;
memset(&sinfo, 0, sizeof(sinfo));
sta_set_sinfo(sta, &sinfo);

i = 0;
Expand All @@ -133,7 +134,7 @@ static void ieee80211_get_stats(struct net_device *dev,
if (sta->sdata->dev != dev)
continue;

sinfo.filled = 0;
memset(&sinfo, 0, sizeof(sinfo));
sta_set_sinfo(sta, &sinfo);
i = 0;
ADD_STA_STATS(sta);
Expand Down

0 comments on commit bfb2781

Please sign in to comment.