ovl: copyattr after setting POSIX ACL

Setting POSIX acl may also modify the file mode, so need to copy that up to the overlay inode. Reported-by: Eryu Guan <[email protected]> Fixes: d837a49 ("ovl: fix POSIX ACL setting") Signed-off-by: Miklos Szeredi <[email protected]>
akeromi · Sep 1, 2016 · ce31513 · ce31513
1 parent 0e585cc
commit ce31513
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
@@ -1018,7 +1018,11 @@ ovl_posix_acl_xattr_set(const struct xattr_handler *handler,
 
 	posix_acl_release(acl);
 
-	return ovl_xattr_set(dentry, handler->name, value, size, flags);
+	err = ovl_xattr_set(dentry, handler->name, value, size, flags);
+	if (!err)
+		ovl_copyattr(ovl_inode_real(inode, NULL), inode);
+
+	return err;
 
 out_acl_release:
 	posix_acl_release(acl);