Skip to content

Commit

Permalink
Merge tag 'modules-for-v4.18' of git://git.kernel.org/pub/scm/linux/k…
Browse files Browse the repository at this point in the history
…ernel/git/jeyu/linux

Pull module updates from Jessica Yu:
 "Minor code cleanup and also allow sig_enforce param to be shown in
  sysfs with CONFIG_MODULE_SIG_FORCE"

* tag 'modules-for-v4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux:
  module: Allow to always show the status of modsign
  module: Do not access sig_enforce directly
  • Loading branch information
torvalds committed Jun 15, 2018
2 parents 8d1e513 + c554b89 commit de7f01c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,7 @@ static void module_assert_mutex_or_preempt(void)
}

static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
#ifndef CONFIG_MODULE_SIG_FORCE
module_param(sig_enforce, bool_enable_only, 0644);
#endif /* !CONFIG_MODULE_SIG_FORCE */

/*
* Export sig_enforce kernel cmdline parameter to allow other subsystems rely
Expand Down Expand Up @@ -2785,7 +2783,7 @@ static int module_sig_check(struct load_info *info, int flags)
}

/* Not having a signature is only an error if we're strict. */
if (err == -ENOKEY && !sig_enforce)
if (err == -ENOKEY && !is_module_sig_enforced())
err = 0;

return err;
Expand Down

0 comments on commit de7f01c

Please sign in to comment.