Skip to content

Commit

Permalink
sparc64: Fix race in arch/sparc64/kernel/trampoline.S
Browse files Browse the repository at this point in the history
Make arch/sparc64/kernel/trampoline.S in 2.6.27.1 lock prom_entry_lock
when calling the PROM.  This prevents a race condition that I observed
causing a hang on startup on a 12-CPU E4500.

I am not subscribed to this list, so please CC me on replies.

Signed-off-by: Andrea Shepard <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
puellavulnerata authored and davem330 committed Oct 23, 2008
1 parent 2515ddc commit e0037df
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions arch/sparc64/kernel/trampoline.S
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,12 @@ after_lock_tlb:

wrpr %g0, 0, %wstate

sethi %hi(prom_entry_lock), %g2
1: ldstub [%g2 + %lo(prom_entry_lock)], %g1
membar #StoreLoad | #StoreStore
brnz,pn %g1, 1b
nop

/* As a hack, put &init_thread_union into %g6.
* prom_world() loads from here to restore the %asi
* register.
Expand All @@ -337,7 +343,7 @@ after_lock_tlb:

sethi %hi(is_sun4v), %o0
lduw [%o0 + %lo(is_sun4v)], %o0
brz,pt %o0, 1f
brz,pt %o0, 2f
nop

TRAP_LOAD_TRAP_BLOCK(%g2, %g3)
Expand Down Expand Up @@ -369,10 +375,10 @@ after_lock_tlb:
call %o1
add %sp, (2047 + 128), %o0

ba,pt %xcc, 2f
ba,pt %xcc, 3f
nop

1: sethi %hi(sparc64_ttable_tl0), %o0
2: sethi %hi(sparc64_ttable_tl0), %o0
set prom_set_trap_table_name, %g2
stx %g2, [%sp + 2047 + 128 + 0x00]
mov 1, %g2
Expand All @@ -386,7 +392,11 @@ after_lock_tlb:
call %o1
add %sp, (2047 + 128), %o0

2: ldx [%l0], %g6
3: sethi %hi(prom_entry_lock), %g2
stb %g0, [%g2 + %lo(prom_entry_lock)]
membar #StoreStore | #StoreLoad

ldx [%l0], %g6
ldx [%g6 + TI_TASK], %g4

mov 1, %g5
Expand Down

0 comments on commit e0037df

Please sign in to comment.