Skip to content

Commit

Permalink
PCI,parisc: Enable 64-bit bus addresses on PA-RISC
Browse files Browse the repository at this point in the history
Commit 3a9ad0b ("PCI: Add pci_bus_addr_t") unconditionally introduced usage of
64-bit PCI bus addresses on all 64-bit platforms which broke PA-RISC.

It turned out that due to enabling the 64-bit addresses, the PCI logic decided
to use the GMMIO instead of the LMMIO region. This commit simply disables
registering the GMMIO and thus we fall back to use the LMMIO region as before.

Reverts commit 45ea2a5
("PCI: Don't use 64-bit bus addresses on PA-RISC")

To: [email protected]
Cc: [email protected]
Cc: Bjorn Helgaas <[email protected]>
Cc: Meelis Roos <[email protected]>
Cc: [email protected]  # v3.19+
Signed-off-by: Helge Deller <[email protected]>
  • Loading branch information
hdeller committed Sep 8, 2015
1 parent 38d9029 commit e02a653
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions drivers/parisc/lba_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1555,8 +1555,11 @@ lba_driver_probe(struct parisc_device *dev)
if (lba_dev->hba.lmmio_space.flags)
pci_add_resource_offset(&resources, &lba_dev->hba.lmmio_space,
lba_dev->hba.lmmio_space_offset);
if (lba_dev->hba.gmmio_space.flags)
pci_add_resource(&resources, &lba_dev->hba.gmmio_space);
if (lba_dev->hba.gmmio_space.flags) {
/* pci_add_resource(&resources, &lba_dev->hba.gmmio_space); */
pr_warn("LBA: Not registering GMMIO space %pR\n",
&lba_dev->hba.gmmio_space);
}

pci_add_resource(&resources, &lba_dev->hba.bus_num);

Expand Down
2 changes: 1 addition & 1 deletion drivers/pci/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# PCI configuration
#
config PCI_BUS_ADDR_T_64BIT
def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC))
def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT)
depends on PCI

config PCI_MSI
Expand Down

0 comments on commit e02a653

Please sign in to comment.