Skip to content

Commit

Permalink
is_power_of_2 in fs/hfs
Browse files Browse the repository at this point in the history
Replace (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by: vignesh babu <[email protected]>
Cc: Roman Zippel <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Vignesh Babu BM authored and Linus Torvalds committed May 8, 2007
1 parent e7d709c commit e1b5c1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion fs/hfs/btree.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/

#include <linux/pagemap.h>
#include <linux/log2.h>

#include "btree.h"

Expand Down Expand Up @@ -76,7 +77,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke
tree->depth = be16_to_cpu(head->depth);

size = tree->node_size;
if (!size || size & (size - 1))
if (!is_power_of_2(size))
goto fail_page;
if (!tree->node_count)
goto fail_page;
Expand Down
3 changes: 2 additions & 1 deletion fs/hfsplus/btree.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include <linux/slab.h>
#include <linux/pagemap.h>
#include <linux/log2.h>

#include "hfsplus_fs.h"
#include "hfsplus_raw.h"
Expand Down Expand Up @@ -69,7 +70,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
}

size = tree->node_size;
if (!size || size & (size - 1))
if (!is_power_of_2(size))
goto fail_page;
if (!tree->node_count)
goto fail_page;
Expand Down

0 comments on commit e1b5c1d

Please sign in to comment.