Skip to content

Commit

Permalink
drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c
Browse files Browse the repository at this point in the history
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
MonamAgarwal authored and gregkh committed Apr 25, 2014
1 parent cb79074 commit e8429b0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/fwserial/fwserial.c
Original file line number Diff line number Diff line change
Expand Up @@ -1807,7 +1807,7 @@ static void fwserial_release_port(struct fwtty_port *port, bool reset)
port->max_payload = link_speed_to_max_payload(SCODE_100);
dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload);

rcu_assign_pointer(port->peer, NULL);
RCU_INIT_POINTER(port->peer, NULL);
spin_unlock_bh(&port->lock);

if (port->port.console && port->fwcon_ops->notify != NULL)
Expand Down Expand Up @@ -2240,7 +2240,7 @@ static int fwserial_create(struct fw_unit *unit)
port->max_payload = link_speed_to_max_payload(SCODE_100);
dma_fifo_init(&port->tx_fifo);

rcu_assign_pointer(port->peer, NULL);
RCU_INIT_POINTER(port->peer, NULL);
serial->ports[i] = port;

/* get unique bus addr region for port's status & recv fifo */
Expand Down

0 comments on commit e8429b0

Please sign in to comment.