Skip to content

Commit

Permalink
IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification
Browse files Browse the repository at this point in the history
commit b7165bd0d6cbb93732559be6ea8774653b204480 upstream.

The specification for the Toeplitz function doesn't require to set the key
explicitly to be symmetric. In case a symmetric functionality is required
a symmetric key can be simply used.

Wrongly forcing the algorithm to symmetric causes the wrong packet
distribution and a performance degradation.

Link: https://lore.kernel.org/r/[email protected]
Cc: <[email protected]> # 4.7
Fixes: 28d6137 ("IB/mlx5: Add RSS QP support")
Signed-off-by: Yishai Hadas <[email protected]>
Reviewed-by: Alex Vainman <[email protected]>
Signed-off-by: Leon Romanovsky <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
yishaih authored and gregkh committed Aug 6, 2019
1 parent 924308d commit e9cd496
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/infiniband/hw/mlx5/qp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1501,7 +1501,6 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
}

MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FN_TOEPLITZ);
MLX5_SET(tirc, tirc, rx_hash_symmetric, 1);
memcpy(rss_key, ucmd.rx_hash_key, len);
break;
}
Expand Down

0 comments on commit e9cd496

Please sign in to comment.