Skip to content

Commit

Permalink
Revert "math64: New div64_u64_rem helper"
Browse files Browse the repository at this point in the history
This reverts commit f792685.

The cputime scaling code was changed/fixed and does not need the
div64_u64_rem() primitive anymore. It has no other users, so let's
remove them.

Signed-off-by: Stanislaw Gruszka <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: [email protected]
Cc: Linus Torvalds <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
Stanislaw Gruszka authored and Ingo Molnar committed Apr 30, 2013
1 parent 68aa8ef commit f300213
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 31 deletions.
19 changes: 1 addition & 18 deletions include/linux/math64.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,6 @@ static inline s64 div_s64_rem(s64 dividend, s32 divisor, s32 *remainder)
return dividend / divisor;
}

/**
* div64_u64_rem - unsigned 64bit divide with 64bit divisor
*/
static inline u64 div64_u64_rem(u64 dividend, u64 divisor, u64 *remainder)
{
*remainder = dividend % divisor;
return dividend / divisor;
}

/**
* div64_u64 - unsigned 64bit divide with 64bit divisor
*/
Expand Down Expand Up @@ -70,16 +61,8 @@ static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
extern s64 div_s64_rem(s64 dividend, s32 divisor, s32 *remainder);
#endif

#ifndef div64_u64_rem
extern u64 div64_u64_rem(u64 dividend, u64 divisor, u64 *remainder);
#endif

#ifndef div64_u64
static inline u64 div64_u64(u64 dividend, u64 divisor)
{
u64 remainder;
return div64_u64_rem(dividend, divisor, &remainder);
}
extern u64 div64_u64(u64 dividend, u64 divisor);
#endif

#ifndef div64_s64
Expand Down
19 changes: 6 additions & 13 deletions lib/div64.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,44 +79,37 @@ EXPORT_SYMBOL(div_s64_rem);
#endif

/**
* div64_u64_rem - unsigned 64bit divide with 64bit divisor and 64bit remainder
* div64_u64 - unsigned 64bit divide with 64bit divisor
* @dividend: 64bit dividend
* @divisor: 64bit divisor
* @remainder: 64bit remainder
*
* This implementation is a modified version of the algorithm proposed
* by the book 'Hacker's Delight'. The original source and full proof
* can be found here and is available for use without restriction.
*
* 'http://www.hackersdelight.org/HDcode/newCode/divDouble.c.txt'
*/
#ifndef div64_u64_rem
u64 div64_u64_rem(u64 dividend, u64 divisor, u64 *remainder)
#ifndef div64_u64
u64 div64_u64(u64 dividend, u64 divisor)
{
u32 high = divisor >> 32;
u64 quot;

if (high == 0) {
u32 rem32;
quot = div_u64_rem(dividend, divisor, &rem32);
*remainder = rem32;
quot = div_u64(dividend, divisor);
} else {
int n = 1 + fls(high);
quot = div_u64(dividend >> n, divisor >> n);

if (quot != 0)
quot--;

*remainder = dividend - quot * divisor;
if (*remainder >= divisor) {
if ((dividend - quot * divisor) >= divisor)
quot++;
*remainder -= divisor;
}
}

return quot;
}
EXPORT_SYMBOL(div64_u64_rem);
EXPORT_SYMBOL(div64_u64);
#endif

/**
Expand Down

0 comments on commit f300213

Please sign in to comment.