Skip to content

Commit

Permalink
[ARM64-BE] Fix byte order of CIE and FDE frames for exception handling
Browse files Browse the repository at this point in the history
Reviewed at http://reviews.llvm.org/D3741



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208792 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
Christian Pirker committed May 14, 2014
1 parent f5864ff commit 62d6aa0
Show file tree
Hide file tree
Showing 2 changed files with 90 additions and 0 deletions.
17 changes: 17 additions & 0 deletions lib/Target/ARM64/MCTargetDesc/ARM64AsmBackend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "llvm/MC/MCFixupKindInfo.h"
#include "llvm/MC/MCObjectWriter.h"
#include "llvm/MC/MCSectionMachO.h"
#include "llvm/MC/MCSectionELF.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MachO.h"
using namespace llvm;
Expand Down Expand Up @@ -500,6 +501,9 @@ class ELFARM64AsmBackend : public ARM64AsmBackend {
const MCFixup &Fixup, const MCFragment *DF,
const MCValue &Target, uint64_t &Value,
bool &IsResolved) override;

void applyFixup(const MCFixup &Fixup, char *Data, unsigned DataSize,
uint64_t Value, bool IsPCRel) const override;
};

void ELFARM64AsmBackend::processFixupValue(const MCAssembler &Asm,
Expand All @@ -523,6 +527,19 @@ void ELFARM64AsmBackend::processFixupValue(const MCAssembler &Asm,
if ((uint32_t)Fixup.getKind() == ARM64::fixup_arm64_pcrel_adrp_imm21)
IsResolved = false;
}

void ELFARM64AsmBackend::applyFixup(const MCFixup &Fixup, char *Data,
unsigned DataSize, uint64_t Value,
bool IsPCRel) const {
// store fixups in .eh_frame section in big endian order
if (!IsLittleEndian && Fixup.getKind() == FK_Data_4) {
const MCSection *Sec = Fixup.getValue()->FindAssociatedSection();
const MCSectionELF *SecELF = static_cast<const MCSectionELF *>(Sec);
if (SecELF->getSectionName() == ".eh_frame")
Value = ByteSwap_32(unsigned(Value));
}
ARM64AsmBackend::applyFixup (Fixup, Data, DataSize, Value, IsPCRel);
}
}

MCAsmBackend *llvm::createARM64leAsmBackend(const Target &T,
Expand Down
73 changes: 73 additions & 0 deletions test/CodeGen/ARM64/big-endian-eh.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
; RUN: llc -mtriple arm64_be-linux-gnu -filetype obj < %s | llvm-objdump -s - | FileCheck %s

; ARM EHABI for big endian
; This test case checks whether CIE length record is laid out in big endian format.
;
; This is the LLVM assembly generated from following C++ code:
;
; extern void foo(int);
; void test(int a, int b) {
; try {
; foo(a);
; } catch (...) {
; foo(b);
; }
;}

define void @_Z4testii(i32 %a, i32 %b) #0 {
entry:
invoke void @_Z3fooi(i32 %a)
to label %try.cont unwind label %lpad

lpad: ; preds = %entry
%0 = landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*)
catch i8* null
%1 = extractvalue { i8*, i32 } %0, 0
%2 = tail call i8* @__cxa_begin_catch(i8* %1) #2
invoke void @_Z3fooi(i32 %b)
to label %invoke.cont2 unwind label %lpad1

invoke.cont2: ; preds = %lpad
tail call void @__cxa_end_catch()
br label %try.cont

try.cont: ; preds = %entry, %invoke.cont2
ret void

lpad1: ; preds = %lpad
%3 = landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*)
cleanup
invoke void @__cxa_end_catch()
to label %eh.resume unwind label %terminate.lpad

eh.resume: ; preds = %lpad1
resume { i8*, i32 } %3

terminate.lpad: ; preds = %lpad1
%4 = landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*)
catch i8* null
%5 = extractvalue { i8*, i32 } %4, 0
tail call void @__clang_call_terminate(i8* %5) #3
unreachable
}

declare void @_Z3fooi(i32) #0

declare i32 @__gxx_personality_v0(...)

declare i8* @__cxa_begin_catch(i8*)

declare void @__cxa_end_catch()

; Function Attrs: noinline noreturn nounwind
define linkonce_odr hidden void @__clang_call_terminate(i8*) #1 {
%2 = tail call i8* @__cxa_begin_catch(i8* %0) #2
tail call void @_ZSt9terminatev() #3
unreachable
}

declare void @_ZSt9terminatev()

; CHECK-LABEL: Contents of section .eh_frame:
; CHECK-NEXT: 0000 0000001c

0 comments on commit 62d6aa0

Please sign in to comment.